Closed Bug 242988 Opened 21 years ago Closed 21 years ago

improve html we emit for vCards

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird0.7

People

(Reporter: mscott, Assigned: mscott)

References

()

Details

(Whiteboard: fixed-aviary1.0)

Attachments

(3 files, 4 obsolete files)

improve html we emit for vCards. what we do right now is very 199x. http://lxr.mozilla.org/mozilla/source/mailnews/mime/cthandlers/vcard/mimevcrd.cpp#320 we should do something slicker, take advantage of gecko's css support. maybe asa or someone in the forums can help. we'll probably need a few minor C++ changes to mimevcrd.cpp, and then let people go crazy with their userContent.css, and when we have a winner, make it the default.
started asking for design ideas here: http://forums.mozillazine.org/viewtopic.php?t=76000
Attached image possible HTML mock up (obsolete) (deleted) —
Here's one possiblity. It gets rid of the "show expanded view" which only works if you have JS on anyway. Just click the icon and you can either add the card to the AB or view all of the properties in a rich address book card UI. Maybe the icon should be top aligned instead of centered...
Attached patch more mockups (obsolete) (deleted) — Splinter Review
I added a couple variations: Moving the icon to the left hand side before the vCard data. Using a Gray border Playing with the "curvature" of the border Aligning the icon on the top Not collapsing the email address into the name (yielding a much wider vCard)
Attachment #148517 - Attachment is obsolete: true
Attachment #148518 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.7
Attached patch work in progress (obsolete) (deleted) — Splinter Review
work in progress patch (although the patch is pretty functional). Still to do: 1) Hook up the vCard icon to actually run the vCard URL, bringing up the address book card dialog. 2) the hover state over the vCard icon isn't working yet We now only show: Name (linkified to personal web page if present), email adddress, job title department and organization inline with the message. To see the other elements you bring up the rich ab card dialog.
Attached patch finished version (obsolete) (deleted) — Splinter Review
Attachment #148601 - Attachment is obsolete: true
for some reason the moz-image region for the hover state of the icon doesn't actually work. Other styles applied to this same hover rule do work just not the moz-image-region.
Attachment #149160 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: fixed-aviary1.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: