Closed
Bug 242988
Opened 21 years ago
Closed 21 years ago
improve html we emit for vCards
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird0.7
People
(Reporter: mscott, Assigned: mscott)
References
()
Details
(Whiteboard: fixed-aviary1.0)
Attachments
(3 files, 4 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
improve html we emit for vCards. what we do right now is very 199x.
http://lxr.mozilla.org/mozilla/source/mailnews/mime/cthandlers/vcard/mimevcrd.cpp#320
we should do something slicker, take advantage of gecko's css support.
maybe asa or someone in the forums can help. we'll probably need a few minor
C++ changes to mimevcrd.cpp, and then let people go crazy with their
userContent.css, and when we have a winner, make it the default.
Assignee | ||
Comment 1•21 years ago
|
||
started asking for design ideas here:
http://forums.mozillazine.org/viewtopic.php?t=76000
Assignee | ||
Comment 2•21 years ago
|
||
Here's one possiblity. It gets rid of the "show expanded view" which only works
if you have JS on anyway. Just click the icon and you can either add the card
to the AB or view all of the properties in a rich address book card UI.
Maybe the icon should be top aligned instead of centered...
Assignee | ||
Comment 3•21 years ago
|
||
I added a couple variations:
Moving the icon to the left hand side before the vCard data.
Using a Gray border
Playing with the "curvature" of the border
Aligning the icon on the top
Not collapsing the email address into the name (yielding a much wider vCard)
Attachment #148517 -
Attachment is obsolete: true
Assignee | ||
Comment 4•21 years ago
|
||
Attachment #148518 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.7
Assignee | ||
Comment 5•21 years ago
|
||
work in progress patch (although the patch is pretty functional).
Still to do:
1) Hook up the vCard icon to actually run the vCard URL, bringing up the
address book card dialog.
2) the hover state over the vCard icon isn't working yet
We now only show: Name (linkified to personal web page if present), email
adddress, job title department and organization inline with the message. To see
the other elements you bring up the rich ab card dialog.
Assignee | ||
Comment 6•21 years ago
|
||
Attachment #148601 -
Attachment is obsolete: true
Assignee | ||
Comment 7•21 years ago
|
||
Assignee | ||
Comment 8•21 years ago
|
||
for some reason the moz-image region for the hover state of the icon doesn't
actually work. Other styles applied to this same hover rule do work just not the
moz-image-region.
Assignee | ||
Updated•21 years ago
|
Assignee | ||
Comment 9•21 years ago
|
||
Attachment #149160 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: fixed-aviary1.0
You need to log in
before you can comment on or make changes to this bug.
Description
•