Closed
Bug 244865
Opened 20 years ago
Closed 20 years ago
MEM Leak in callbacks.c using SSL_RevealURL
Categories
(JSS Graveyard :: Library, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glenbeasley, Assigned: glenbeasley)
Details
(Keywords: memory-leak)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
SSL_RevealURL returns the alocated hostname which needs to be freed
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•20 years ago
|
Attachment #149427 -
Attachment description: set value to NULL, and will free at exit → init to NULL, and if not NULL free at exit
|
||
Updated•20 years ago
|
OS: SunOS → Solaris
|
|
Assignee | |
Updated•20 years ago
|
Attachment #149427 -
Flags: superreview?(wchang0222)
Attachment #149427 -
Flags: review?(julien.pierre.bugs)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 149427 [details] [diff] [review]
init to NULL, and if not NULL free at exit
r=wtc.
I encourage you to free 'hostname' earlier, right
after the "if (hostname && hostname[0]) ... else ..."
statements. In the second case, you can even declare
'hostname' inside the 'else' block where it's used.
Attachment #149427 -
Flags: superreview?(wchang0222) → superreview+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 149427 [details] [diff] [review]
init to NULL, and if not NULL free at exit
The patch is correct.
However, while reviewing the patch, I found an issue that affects this code .
See bug 245950 .
Attachment #149427 -
Flags: review?(julien.pierre.bugs) → review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
changed to wan-teh's suggestions.
Attachment #149427 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•20 years ago
|
||
/cvsroot/mozilla/security/jss/org/mozilla/jss/ssl/callbacks.c,v <-- callbacks.c
new revision: 1.10; previous revision: 1.9
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•20 years ago
|
Version: 3.4.2 → 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•