Closed Bug 245524 Opened 20 years ago Closed 20 years ago

Calendar dependancies removed from FF 0.9

Categories

(Calendar :: Sunbird Only, defect)

x86
All
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: Callek, Assigned: mostafah)

References

Details

Attachments

(2 files)

There are missing/blank areas in the latest Nightly of FF with calendar installed. This prevents Calendar's use. probably due to comm.jar changes, maybe others though.
From a "Search in files:" for ref Find all "communicator", Subfolders, Find Results 2, "D:\Mozilla\Sources\Trunk\mozilla\calendar", "*.*" D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\attachFile.js(12): * The Original Code is Mozilla Communicator client code, released D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\calendar.js(1551): window.openDialog("chrome://communicator/content/wallet/SignonViewer.xul", D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\calendar.xul(50):<?xml-stylesheet href="chrome://communicator/skin/communicator.css" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\calPrintEngine.xul(13):The Original Code is Mozilla Communicator client code, released D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\calPrintEngine.xul(22):<?xml-stylesheet href="chrome://communicator/content/communicator.css" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\calPrintEngine.xul(27):?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"? D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\calPrintEngine.xul(53): <script type="application/x-javascript" src="chrome://communicator/content/printing.js"/> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\contents.rdf(62): <RDF:li resource="chrome://communicator/content/tasksOverlay.xul"/> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\contents.rdf(63): <RDF:li resource="chrome://communicator/content/pref/preftree.xul"/> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\contents.rdf(64): <RDF:li resource="chrome://communicator/content/pref/pref-appearance.xul"/> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\contents.rdf(72): <RDF:Seq about="chrome://communicator/content/tasksOverlay.xul"> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\contents.rdf(77): <RDF:Seq about="chrome://communicator/content/pref/preftree.xul"> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\contents.rdf(82): <RDF:Seq about="chrome://communicator/content/pref/pref-appearance.xul"> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\eventDialog.xul(81):<script type="application/x-javascript" src="chrome://communicator/content/utilityOverlay.js"/> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\menuOverlay.xul(43):<?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\printDialog.xul(78):<script type="application/x-javascript" src="chrome://communicator/content/utilityOverlay.js"/> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\toDoDialog.xul(79):<script type="application/x-javascript" src="chrome://communicator/content/utilityOverlay.js"/> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\wizard.xul(42):<?xml-stylesheet href="chrome://communicator/skin/communicator.css" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\pref\.#prefOverlay.xul.1.10(49): if ((panel != undefined)&&(panel == "chrome://communicator/content/pref/pref-appearance.xul")) D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\pref\alarmPrefs.xul(39):<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\pref\calendarPref.xul(40):<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\pref\prefOverlay.xul(49): if ((panel != undefined)&&(panel == "chrome://communicator/content/pref/pref-appearance.xul")) D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\pref\publishPrefs.xul(41):<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\pref\timezonePrefs.xul(40):<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\content\pref\viewPrefs.xul(41):<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?> D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\skin\classic\overlay.css(64): list-style-image: url("chrome://communicator/skin/taskbar/mail-16.gif"); D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\skin\classic\overlay.css(68): list-style-image: url("chrome://communicator/skin/taskbar/addressbook-16.gif"); D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\skin\classic\overlay.css(72): list-style-image: url("chrome://communicator/skin/taskbar/navigator-16.gif"); D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\skin\modern\overlay.css(64): list-style-image: url("chrome://communicator/skin/taskbar/mail-16.gif"); D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\skin\modern\overlay.css(68): list-style-image: url("chrome://communicator/skin/taskbar/addressbook-16.gif"); D:\Mozilla\Sources\Trunk\mozilla\calendar\resources\skin\modern\overlay.css(72): list-style-image: url("chrome://communicator/skin/taskbar/navigator-16.gif"); D:\Mozilla\Sources\Trunk\mozilla\calendar\sunbird\Makefile.in(54): mkdir -p ./MozillaSunbird/chrome/overlayinfo/communicator/content/ D:\Mozilla\Sources\Trunk\mozilla\calendar\sunbird\Makefile.in(102): cp $(topsrcdir)/dist/bin/chrome/overlayinfo/communicator/content/overlays.rdf ./MozillaSunbird/chrome/overlayinfo/communicator/content D:\Mozilla\Sources\Trunk\mozilla\calendar\sunbird\app\splash.rc(15): * The Original Code is Mozilla Communicator client code. D:\Mozilla\Sources\Trunk\mozilla\calendar\sunbird\app\splashos2.rc(13): * The Original Code is Mozilla Communicator client code. D:\Mozilla\Sources\Trunk\mozilla\calendar\sunbird\base\content\calendar.xul(50):<?xml-stylesheet href="chrome://communicator/skin/communicator.css" type="text/css"?> Total found: 36 Matching files: 23 Total files searched: 556
we also need to re-aim the files: toolkit.jar!/content/global/nsJSSupportsUtils.js and toolkit.jar!/content/global/nsJSComponentManager.js
After thinking on how much of a blocker this is, here are a list of Files and line #'s only: Files which only refer to "communicator" in comment: (1) resources\content\attachFile.js (line 12) Files which use communicator but do not need to be changed: (2) resources\content\calendar.js (line 1551) References which may need to be changed: (3) resources\content\calendar.xul (line 50) (4) resources\content\calPrintEngine.xul (line 22) (line 53) (5) resources\content\eventDialog.xul (line 81) (6) resources\content\menuOverlay.xul (line 43) (7) resources\content\printDialog.xul (line 78) (8) resources\content\toDoDialog.xul (line 79) (9) resources\content\wizard.xul (line 42) (10) resources\content\pref\alarmPrefs.xul (line 39) (11) resources\content\pref\calendarPref.xul (line 40) among a few others, getting tired right now to look up and add the rest. (2) is ok since we call the communicator "Wallet" code through a function, that the only access to is on a hidden menu-item, shown if Wallet is present. [correct me if I am wrong on that thinking] perhaps we can use similar methods for other areas which call communicator.
see Fixed bug 243091 for a ref of changed stuff.
going to create a few attachments, of works in progress these need some work, and I'll be busy for the next few days, so not sure how much I can work on them, someone please take the task. Thoughts: My attachments are menu stuff, the JS fix would be to use the communicator file(s) if they exist, and our forked, minimal version otherwise (if needed) or drop the feature, suggestion is to use a version of JSLib's include function, which we can trap in a try{}catch{} to see if it was included.
entering in text/plain for easy viewing, this is a prelim, some of these comments may need to be removed or more added in, final version should have all commented out code removed entirely, keep the xpi smaller if possible. Also need to fork platformOverlay's which is easier to deal with since we already compile for multiple platforms. (using a makefile and jar.mn's)
This is a work in progress of menuOverlay.xul the dtd's used in both these still need to be forked to cal dtd's, (en-US/forked/... is my suggestion).
This bug should no longer be valid, Cal works (now) in Firefox. Marking WFM
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: