Creating a new bookmark by dragging the favicon into a toolbar folder creates a bookmark at the top of the folder, whereas adding a bookmark to any folder using "Add Page to Bookmarks" always creates the bookmark at the bottom of the target folder. We should be consistent (probably changing the DnD to add to the bottom).

Nominating for 0.9, since there will hopefully be some bookmark code cleanup by then, and this is something that would likely be fixed by sensible refactoring of the code.

This patch does the following: 1. Fixes this bug 2. Cleans up the dropDestinationValid: method in BookmarkToolbar.mm, in which a variable has values assigned to it in a few places but it is never actually used. It also cleans up formatting in the method. 3. Cleans up performDragOperation: formatting. This is the method that contains the fix for this bug. 4. Cleans up some formatting in BookmarkToolbar.h

By "fixes this bug" I mean it makes dropping things on toolbar folders append to the end of a folder instead of the beginning.

Comment on attachment 157583 [details] [diff] [review] fix v1.0 This works as described and looks fine. The only (minor) thing I see is that, since you're touching -dropDestinationValid you might want to move the else if on line 448 to line 447 with the closing brace. r=me@mollyandgeoff.com

landed on trunk. should this go on the branch (just the index = 0 removal changes)?

landed on branch.