Closed Bug 246525 Opened 20 years ago Closed 20 years ago

Cache entries shall have intl-friendly date and time format (about:cache)

Categories

(Core :: Networking, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: cnst+bmo, Assigned: cnst+bmo)

References

()

Details

(Keywords: intl, l12y)

Attachments

(1 file)

Mozilla shows date and time in a dodgy format under the about:cache family of addresses. Official Mozilla 1.6 on Windows XP: << Key: http://www.mozilla.org/images/mlogo.gif Data size: 62172 Bytes Fetch count: 16 Last Modified: 06/12/04 19:23:15 Expires: 07/04/04 02:34:03 >> Mozilla on FreeBSD: << Data size: 62172 bytes Fetch count: 1 Last modified: Sat 12 Jun 21:54:53 2004 Expires: Tue 29 Jun 11:08:49 2004 >> A simple patch is to follow.
Attached patch the patch to use ISO 8601 (deleted) — Splinter Review
Attachment #150629 - Flags: superreview?(darin)
Attachment #150629 - Flags: review?(cbiesinger)
Comment on attachment 150629 [details] [diff] [review] the patch to use ISO 8601 hmm. maybe this should use http://lxr.mozilla.org/seamonkey/source/intl/locale/public/nsIDateTimeFormat.h# 65 instead? the function signature would have to change, of course...
(In reply to comment #2) > (From update of attachment 150629 [details] [diff] [review]) > hmm. maybe this should use > http://lxr.mozilla.org/seamonkey/source/intl/locale/public/nsIDateTimeFormat.h# > 65 instead? the function signature would have to change, of course... I was thinking about that. But in that case, it would be strange to have American English description with, let's say, Russian style date and time in Cyrillic script... Maybe it should be properly localised first, before using locale's date and time?
Comment on attachment 150629 [details] [diff] [review] the patch to use ISO 8601 hm, good point. localizing this is probably not worth the time.
Attachment #150629 - Flags: review?(cbiesinger) → review+
Comment on attachment 150629 [details] [diff] [review] the patch to use ISO 8601 sr=darin
Attachment #150629 - Flags: superreview?(darin) → superreview+
Checking in netwerk/protocol/about/src/nsAboutCache.cpp; /cvsroot/mozilla/netwerk/protocol/about/src/nsAboutCache.cpp,v <-- nsAboutCache.cpp new revision: 1.36; previous revision: 1.35 done Checking in netwerk/protocol/about/src/nsAboutCacheEntry.cpp; /cvsroot/mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp,v <-- nsAboutCacheEntry.cpp new revision: 1.26; previous revision: 1.25 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 94081 has been marked as a duplicate of this bug. ***
(In reply to comment #7) > *** Bug 94081 has been marked as a duplicate of this bug. *** I reported bug 94081 and (as suggested in comment #2) I would much prefer that Mozilla uses my locale's format instead of imposing any format of its own. p.s. I don't have the problems mentioned in comment #3 as the misleading date is the only Americanism in about:cache
(In reply to comment #8) > I reported bug 94081 and (as suggested in comment #2) I would much prefer that > Mozilla uses my locale's format instead of imposing any format of its own. All strings in about:cache are hard-coded. Therefore, using locale date will only confuse non-English speakers. Anyhow, about:cache is only intended for advanced users, who are very likely to have no problems with ISO 8601. > p.s. I don't have the problems mentioned in comment #3 as the misleading > date is the only Americanism in about:cache It surely not. :-) In en-GB we have "disc", in about:cache we have "disk". Localisation of about:cache is welcome in another bug. :-) More comments in this bug are irrelevant.
Attachment #150629 - Flags: approval1.7.1?
The HTTP headers are exchanged in this format, so I think this is an improvement... Date: Fri, 17 Sep 2004 17:43:11 GMT
Comment on attachment 150629 [details] [diff] [review] the patch to use ISO 8601 I don't see a reason to put this in 1.7
Attachment #150629 - Flags: approval1.7.x? → approval1.7.x-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: