Robert Marcano Reporter
	Description • 20 years ago

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 Epiphany/1.2.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 Epiphany/1.2.4

Using a binding like this one

  <binding id="input">
    <content>
      <children includes="label"/>:
      <html:input type="text" title="This title is not displayed" anonid="input"/>
      <children/>
    </content>
  </binding>

works as designed, with the exception the the generated HTML input element does
not show the tooltip required by the title attribute. The same input element
added to the document directly (no XBL) shows the tooltip


Reproducible: Always
Steps to Reproduce:
1. add the binding to a element
2. go to the generated html input field
3. wait for the tooltip

Actual Results:  
the tooltip will not be showed

Expected Results:  
the tooltip must be showed like any non XBL generated HTML element

	Martijn Wargers (dead)
	Comment 1 • 20 years ago

Like this? This doesn't produce a tooltip when hovering over the link.

	Robert Marcano Reporter
	Comment 2 • 20 years ago

yes, nice testcase, I never thought on this method to add a binding only using
the XHTML file (binding on the same file) ;-)

	neil@parkwaycc.co.uk
	Comment 3 • 20 years ago

bryner, does the tooltip listener need to get the original event target?

	neil@parkwaycc.co.uk
	Comment 4 • 20 years ago

Actually now that I think about it this bug is probably invalid; only XUL
supports tooltips, and the fact that tooltips appear for titled HTML elements in
web pages is simply some smart JavaScript plus XUL behind the scenes.

	Hixie (not reading bugmail)
	Comment 5 • 20 years ago

The title="" attribute for HTML elements should always generate a tooltip,
wherever that HTML element is.

	Martijn Wargers (dead)
	Comment 6 • 19 years ago

This patch fixes the testcase and also when you use the context menu on the anonymous link element.

	Brian Ryner (not reading)
	Comment 7 • 19 years ago

Comment on attachment 207374 [details] [diff] [review]
patchv1

Can you ask Neil and/or Boris to review this?  I'm not sure that exposing arbitrary anonymous content via document.popupNode is really a good idea.

	Boris Zbarsky [:bzbarsky]
	Comment 8 • 19 years ago

Hmm...  That worries me too.  I really wish we weren't storing this stuff on the document.  :(  As things stand, I'm not sure who's relying on document.popupNode being something in particular.

If nothing else, if we allow anon content in document.popupNode we should look over the security checks on that method and make sure they're up to snuff.

	neil@parkwaycc.co.uk
	Comment 9 • 19 years ago

Comment on attachment 207374 [details] [diff] [review]
patchv1

>       if (eventTarget) {
>         nsCOMPtr<nsIContent> targetContent(do_QueryInterface(eventTarget));
>         mTargetNode = targetContent;
>       }
Heh, it seems to me that this is the equivalent of mTargetNode = do_QueryInterface(eventTarget); (since it should always be null prior to this point)

>+  nsEvent->GetOriginalTarget(getter_AddRefs(target));
>+  
>   nsCOMPtr<nsIDOMNode> targetNode = do_QueryInterface(target);
>+  
>+  nsCOMPtr<nsIContent> targetContent(do_QueryInterface(targetNode));
>+  
>+  if (targetContent->IsNativeAnonymous()) {
>+    for ( ; targetContent; targetContent = targetContent->GetParent()) 
>+    {
>+      if (!targetContent->IsNativeAnonymous()) {
>+        targetNode =  do_QueryInterface(targetContent);
>+        break;
>+      }
>+    }
>+  }
It seems to me that this could be written as follows:
nsEvent->GetOriginalTarget(getter_AddRefs(target));
nsCOMPtr<nsIContent> targetContent(do_QueryInterface(targetNode));
while (targetContent->IsNativeAnonymous())
  targetContent = targetContent->GetParent();
nsCOMPtr<nsIDOMNode> targetNode = do_QueryInterface(targetContent);

I forget the bug but I seem to remember someone requesting that originalTarget be retargetted for anonymous nodes which would in fact make the loop unnecessary.

	Brian Ryner (not reading)
	Comment 10 • 19 years ago

Maybe nothing relies on popupNode, but tooltipNode is affected the same way, and that's used to position tooltips for HTML elements (from browser.js).

(In reply to comment #8)
> Hmm...  That worries me too.  I really wish we weren't storing this stuff on
> the document.  :(  As things stand, I'm not sure who's relying on
> document.popupNode being something in particular.

	neil@parkwaycc.co.uk
	Comment 11 • 19 years ago

(In reply to comment #8)
>I really wish we weren't storing this stuff on the document.  :(
So document.originalPopupNode is out I guess...
>I'm not sure who's relying on document.popupNode being something in particular.
In our codebase, I can only find one use in mailWidgets.xml and that can probably be worked around using (display=?) extends="xul:button" - all the other elements with context menus already have an appropriate button or menu frame.

(In reply to comment #10)
>Maybe nothing relies on popupNode, but tooltipNode is affected the same way,
>and that's used to position tooltips for HTML elements (from browser.js).
Well we could easily fix that by positioning tooltips in screen coordinates.

	Boris Zbarsky [:bzbarsky]
	Comment 12 • 19 years ago

In this case we'd _want_ to use the originalTarget for positioning, no?

	Martijn Wargers (dead)
	Comment 13 • 19 years ago

(In reply to comment #9)
Yes, these suggestions seem to make all sense to me.

> I forget the bug but I seem to remember someone requesting that originalTarget
> be retargetted for anonymous nodes which would in fact make the loop
> unnecessary.
I think you mean bug 251197, comment 12, right?

(In reply to comment #7)
> (From update of attachment 207374 [details] [diff] [review] [edit])
> Can you ask Neil and/or Boris to review this?  I'm not sure that exposing
> arbitrary anonymous content via document.popupNode is really a good idea.
I don't really understand. With that targetContent->IsNativeAnonymous loop, you should never get native anonymous content, only xbl anonymous content, which isn't arbritrary anonymous content, is it? (but apparently I'm missing something here, please enlighten me)

	Martijn Wargers (dead)
	Comment 14 • 19 years ago

Or should I use GetExplicitOriginalTarget? But afaics, that also retargets when it is xbl anonymous content.