Closed
Bug 24971
Opened 25 years ago
Closed 24 years ago
[Wizard] New UI for Create New Mail Account needed
Categories
(SeaMonkey :: MailNews: Account Configuration, defect, P3)
SeaMonkey
MailNews: Account Configuration
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bugzilla, Assigned: alecf)
Details
Attachments
(4 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
After seeing the really cool UI for the Profile stuff (Create New
Profile, Select Profile, etc) I'm think there should be a
cool UI for the Create New Mail Account Wizard too!
The current one, works ok, but compared to the Profile UI it looks lame!
Comment 1•25 years ago
|
||
Maybe Ben Goodger (ben@netscape.com) could do something cool here.
Updated•25 years ago
|
QA Contact: lchiang → nbaca
Assignee | ||
Comment 3•25 years ago
|
||
absolutely. oohhhh beeeenn...
BTW, the spec is at http://www.mozilla.org/mailnews/specs/accounts/index.html
Status: NEW → ASSIGNED
Component: Front End → Account Manager
Summary: New UI for Create New Mail Account needed → [Wizard] New UI for Create New Mail Account needed
Comment 4•25 years ago
|
||
oh no
ahhhhhhhhh!!!!
check in the new code and I'll whack the UI.
Assignee: alecf → ben
Status: ASSIGNED → NEW
Assignee | ||
Comment 5•25 years ago
|
||
all checked in, just waiting for ya
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 6•25 years ago
|
||
M19 because I think this is a slightly higher priority than the bugs I just
pushed to M20 ;)
Target Milestone: M16 → M19
Ben, isn't this done already or should we escalate this as a feature for beta 2?
Target Milestone: M19 → M21
Assignee | ||
Comment 8•24 years ago
|
||
I did this already. reassigning back to me and marking fixed.
Assignee: ben → alecf
Status: ASSIGNED → NEW
Comment 9•24 years ago
|
||
The wizard still needs to be fully converted over to xul widgets and could use
some other ui enhancements...I've been working on this, so I'm going to steal
this (if you don't mind, alec...)
Assignee: alecf → BlakeR1234
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•24 years ago
|
||
wow, that's awesome. Blake, if you end up rewriting wizardHandler/etc for this,
can you rewrite it as nsWizardHandler.js and leave the old one in place? I
believe we have some code in the commercial tree that's depending on
wizardHandler.js/etc, and ben has already rewritten the widgetStateManager as
nsWidgetStateManager.js.. thanks!
Reporter | ||
Comment 11•24 years ago
|
||
I like to help in testing, giving good idea's, etc...
OS: Windows 98 → All
Hardware: PC → All
Assignee | ||
Comment 12•24 years ago
|
||
actually, I did this a long time ago, the only thing that's missing is the icon.
Comment 13•24 years ago
|
||
alec, you did what a long time ago? most of the interface is still in xul; i
also changed some other stuff to make it nicer
Assignee | ||
Comment 14•24 years ago
|
||
I made the new UI for the mail wizard - i.e. this bug was to make the mail
wizard have the same style as the new profile wizard. The only thing that's
missing is an icon in the upper left hand corner.
I just realized I commented in this bug with the "That's really awesome" - what
I meant was that you're converting it over to XUL widgets from HTML
widgets...that's actually bug 35427. Do you want to take that one?
Note that we have a UI spec on http://www.mozilla.org/mailnews/specs/accounts/
that describes what the wizard should look like, the phrasing of sentences, etc.
(except the header in the wizard, which I've changed to use the
dark-blue-toolbar-style bar)
Comment 15•24 years ago
|
||
we need to decide what icon to use for the wizard so i can add it and mark this
fixed.
Reporter | ||
Comment 16•24 years ago
|
||
I have a hard time seeing that this bug is fixed. The two dialogs, the "Create
Profile" and "New Account Setup" doesn't look the same:
- Large weird looking outer margin in "New Account Setup".
- No bottom status line in "New Account Setup". Where it in Create Profile fx
says "page 1 of 2".
- Missing horizontal line above buttoms.
- Text should be inside "square" not entire dialog inside "square"
Will attach screen shot to show...
Reporter | ||
Comment 17•24 years ago
|
||
Comment 18•24 years ago
|
||
The dialogs don't have to be _exactly_ the same, but I'll look in to the
changes you suggested.
also, fwiw, the green borders that you see in each dialog is the result of
using an HTML widget (in the case of the account wizard, html:iframe)...those
won't be there once converted to xul widgets.
Reporter | ||
Comment 19•24 years ago
|
||
Comment 20•24 years ago
|
||
Henrik, that looks nice, but I'm doubtful that you did all the backend required
for the XUL conversion. Does the wizard still function exactly the same (and
remember the values if you navigate backwards and forwards)?
Reporter | ||
Comment 21•24 years ago
|
||
I've changed nuthing but the layout. The functionality is 110% the same...
Comment 22•24 years ago
|
||
Henrik, did you convert the two radio widgets in the first screen to
<radiogroup> and <radio>'s yourself? And did you just change the XUL (not any
underlying JS)? Please ensure that choosing, say, "Newsgroup Account", then
pressing Next, then pressing Back will prefill "Newsgroup Account" again.
Reporter | ||
Comment 23•24 years ago
|
||
I've changed the dialog to use the radiogruop and added the statusline, and
tweaked the UI. Everything works the way it used to... Including moving back and
forth.
Comment 24•24 years ago
|
||
hmm...alec?
Assignee | ||
Comment 25•24 years ago
|
||
attach a patch, I'll test it, possibly check it in. :)
Reporter | ||
Comment 26•24 years ago
|
||
Reporter | ||
Comment 27•24 years ago
|
||
Comment 28•24 years ago
|
||
alec: how do the patches look to you?
reassigning to henrik for now...as no one ever told me what icon needed to be
added to the wizard, this bug has just been sitting in my list...
Reporter | ||
Comment 29•24 years ago
|
||
I dont like to have bugs assigned to me, since I dont have CVS checkin
rights...:)
Assignee: gemal → alecf
Assignee | ||
Comment 30•24 years ago
|
||
bug 54028 covers the last remaning issue here, so I'm just going to mark this
fixed, and anyone who is interested in the icon issue, go see that bug.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 31•24 years ago
|
||
Marking Verified on Branch
WinNT 2000102008
Mac 2000102008
Linux 2000102009
Keywords: vtrunk
Comment 32•24 years ago
|
||
Verified Fixed on Mozilla trunk builds
linux 102308 RedHat 6.2
win32 102304 NT 4
mac 102312 Mac OS9
Setting bug to Verified and removing vtrunk keyword
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•