I would really love this as well. Ideally just a button or two under/in the saved passwords button. A simple json dump is fine and if I have to toggle something is about:config to enable this so be it.

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.

(In reply to Danny Colin [:sdk] from comment #29)

Lockwise needs a Firefox Account and even if it's made by Firefox, it implies that your password will be sync'ed to an online service. I don't think we should force a user to use a cloud service for that kind of sensitive information.

While I agree in principle (and Firefox gives one the choice to turn off Firefox Sync), Firefox Sync is very private---it is just as private as sync services used by other password managers---the passwords are encrypted locally using your master password and only then sent to the servers. In other words, no plaintext password leaves your computer.

(In reply to sanketh from comment #32)

While I agree in principle (and Firefox gives one the choice to turn off Firefox Sync), Firefox Sync is very private---it is just as private as sync services used by other password managers---the passwords are encrypted locally using your master password and only then sent to the servers. In other words, no plaintext password leaves your computer.

Yes I learned about the passwords being encrypted locally a few weeks after my comment ;). However, the article doesn't mention the master password.

(In reply to Danny Colin [:sdk] from comment #33)

Yes I learned about the passwords being encrypted locally a few weeks after my comment ;). However, the article doesn't mention the master password.

I meant to say the account password. Sorry about that, other password managers use the term "master password" so my mind jumped to it. :-)

(In reply to sanketh from comment #32)

(In reply to Danny Colin [:sdk] from comment #29)

Lockwise needs a Firefox Account and even if it's made by Firefox, it implies that your password will be sync'ed to an online service. I don't think we should force a user to use a cloud service for that kind of sensitive information.

While I agree in principle (and Firefox gives one the choice to turn off Firefox Sync), Firefox Sync is very private---it is just as private as sync services used by other password managers---the passwords are encrypted locally using your master password and only then sent to the servers. In other words, no plaintext password leaves your computer.

The export/backup option is not about how secure or not sync is. I trust the mozilla team and I trust that sync is in a good place. This is about the portability of my data. Should I need or want to export my accounts and passwords I am currently unable to do so and I would like a way to back them up myself.

All that said; thank you for lockwise. I do really enjoy the new password management in firefox :)

In terms of UI we would want to add a menu item to the meatball menu in the top-right of about:logins.

My main open question is the file format, CSV seems to be the standard, but the naming of the columns needs to be determined. One hurdle will be figuring out how to handle formActionOrigin and httpRealm in the export file. Do any other password managers import those? I believe Chrome uses both but idk if they export them.

I would like to pick this up but since good is better than perfect I would like to first focus on the most high value thing: export passwords. I see comments regarding exporting everything, importing passwords, changing structure and so on. I would like to implement a meatball menu in about:logins that just exports the passwords. I will look into other password managers and post here what formats they prefer. Trying not to re-invet the wheel here.

Does it sound good? Should I just assign this to myself? This would be my first contribution to Firefox so I guess I will need some mentoring. I'll try not to spam the #lockwise Riot room too much :D

It turns out that exporting was really really trivial (hope I'm on the right track here).

I have a few questions:

• what fields to I export? Here is the full list: guid, timeCreated, timeLastUsed, timePasswordChanged, timesUsed, username, password, origin, displayOrigin, hostname, formActionOrigin, formSubmitURL, httpRealm, usernameField, passwordField, title;
• do I keep the field names as they are?
• should Import be idempotent? Should existing entries rely on guid to replace the same entity in from a previous export?
• how should the import look like? Meatball menu and open csv dialog?

https://phabricator.services.mozilla.com/D75716

I cannot assign this ticket to me.
What Icons should I use for export and import? I see there is an "import" icon and an "import export" https://design.firefox.com/icons/viewer/ are they fit for this or should I use others?

Andrei,

What fields appear in your export?

As a baseline, this is what Chromium exports on my machine:

name,url,username,password
slickdeals.net,https://slickdeals.net/forums/login.php,test,passwords

my patch has url, user, password. I want to add more with guid at least. Not sure about the other fields.

Matt, what if we export/import all the fields?
I expect that if I make a backup, mess up my profile and import from backup to have ALL my data exactly how it was before.
Looking into what fields other password managers save is not useful for this task. It's useful only for importing from other password managers.

FWIW, I think it is fine for Firefox import/export to be a superset of what other password managers provide, but I think it would be useful to maintain equivalence on column names (when possible) with other password manager exports to ease migration.

It would be ideal if Firefox would ignore unrecognized column names when importing to maintain compatibility (for example, if importing from Bitwarden or Chromium).

Having different column names complicates the code. If the Firefox code has "origin", mapping it to "url" when exporting and then back from "url" to "origin" is code that brings no value. What if Chrome decides to rename their exports to "address".

I think this sort of mapping should be in only one place: import from other tool into Firefox. There should be a importFromChrome(), importFromBitwarden(), importFromLastpass() and they should actually keep these mapings.

Not sure who has authority on this sort of decisions. Tons of people are following and commenting here.

Another question: should I ask for master password during export/import?

KeepassXC uses "Group","Title","Username","Password","URL","Notes". I assume most programs don't care about the case, so using url, username, password like Chrome makes sense to me. I think doing some minimal mapping on this data for compatibility with other programs would be useful.

Not having anything to do with this but i do agree with petcuandrei: if we keep following others nomenclature we'll be always be playing "chase", because, as we all now, Google, for example, has a long history of changing things just for the sake of changing them (and break competition's tools in the meanwhile). So i don't think i feel like running to chase others...

As for asking for master password during export/import, from my point of view, i would say "absolutely"!
I don't want my passwords exported in seconds by some "friend" while i use the WC.
LOLOL

For transparency: I've been talking with the assignee on chat and in Phabricator for the last few days. Just now getting around to answering some other questions here.

(In reply to petcuandrei from comment #37)

I would like to pick this up but since good is better than perfect I would like to first focus on the most high value thing: export passwords.

Good, this bug is only about export but we need to be able to import our own export so keeping import in mind is helpful.

I will look into other password managers and post here what formats they prefer. Trying not to re-invet the wheel here.

That's good. Less mapping of column names and formats will be nice. If you don't research this now we will regret it later.

(In reply to petcuandrei from comment #39)

It turns out that exporting was really really trivial (hope I'm on the right track here).

Yes, it's technically trivial. The hardest part is researching column names/formats so that our import code doesn't need to special case for each source application.

I have a few questions:

• do I keep the field names as they are?

If a popular password manager already has appropriate names for the same data it may be useful to align with them. Note that some password managers use full URLs but currently we store origins.

• should Import be idempotent?

Ideally, yes, at least for the non-metadata fields (origin/username/password)

Should existing entries rely on guid to replace the same entity in from a previous export?

LoginHelper.maybeImportLogins can already update existing logins for import from other browsers using the combination of ( login.origin, login.formActionOrigin, login.httpRealm) but if we could also use the GUIDs if they exist. This is a problem we don't need to worry about in this bug, only in bug 1303176 (which can also handle our own CSV files), but it's fine to export the GUID.

• how should the import look like? Meatball menu and open csv dialog?

Let's leave that for bug 1303176.

(In reply to petcuandrei from comment #44)

Matt, what if we export/import all the fields?

That's okay but I agree with Tom and Asif that we should try and re-use existing column names where it's possible and helpful.

I expect that if I make a backup, mess up my profile and import from backup to have ALL my data exactly how it was before.

I agree for the most part. Though for that use case you can backup the values encrypted instead (logins.json + key4.db).

Looking into what fields other password managers save is not useful for this task. It's useful only for importing from other password managers.

It's useful for making our import code simpler so we don't need to handle importing our own file format significantly differently than other CSV files.

(In reply to petcuandrei from comment #46)

Having different column names complicates the code. If the Firefox code has "origin", mapping it to "url" when exporting and then back from "url" to "origin" is code that brings no value. What if Chrome decides to rename their exports to "address".

It will make it easier for people to import the Firefox CSV in other password managers that already handle those column names. Doing the mapping on export means on less mapping to handle on import if we already need that mapping to support existing CSV in the wild.

I think this sort of mapping should be in only one place: import from other tool into Firefox. There should be a importFromChrome(), importFromBitwarden(), importFromLastpass() and they should actually keep these mapings.

I don't think we will need functions specific to each application, I'm hoping the column name should be sufficient with some transformations on the data value.

Not sure who has authority on this sort of decisions. Tons of people are following and commenting here.

I will review the code :)

Another question: should I ask for master password during export/import?

Yes, use the helper we will land in bug 1639347 which will handle using master password or the OS auth. (if enabled)

Thanks for working on this :)

Thank you for the aggregated response here + the motivation behind each choice!

Hi Andrei,
I just chatted with MattN - here's where we got...
• Use Save Dialog (not the Download dialog)
• Window Title: for Save dialog - "Export Logins File" (matches what we do for export bookmarks)
• default filename "logins.csv"
• Menu order:

1. Import...
2. Export...

3. Preferences

(In reply to katieC from comment #51)

• Use Save Dialog (not the Download dialog)
• Window Title: for Save dialog - "Export Logins File" (matches what we do for export bookmarks)
• default filename "logins.csv"

For this you can use code like the bookmark HTML export. To filter to CSV use appendFilter.

Which icon? share https://phabricator.services.mozilla.com/D75716#2314515 or save? https://bugzilla.mozilla.org/show_bug.cgi?id=1639348#c1

(In reply to petcuandrei from comment #53)

Which icon? share https://phabricator.services.mozilla.com/D75716#2314515 or save? https://bugzilla.mozilla.org/show_bug.cgi?id=1639348#c1

For this bug I don't think it matters, as we can swap it later, but save seems slightly better IMO. (chrome://browser/skin/save.svg)

https://hg.mozilla.org/mozilla-central/rev/863025bf6b1c

Thank you very much for fixing this bug.

FYI for others that this menu item is hidden for now until we fix some of the follow-up bugs.

+1 on the thanks :)

(In reply to Matthew N. [:MattN] from comment #57)

FYI for others that this menu item is hidden for now until we fix some of the follow-up bugs.

This should be enabled sometime tomorrow.

Release Note Request (optional, but appreciated)
[Why is this notable]: Long-awaited feature (16 years) with 42 CCs and 17 votes. We get regular requests on Reddit and GitHub for this.
[Affects Firefox for Android]: No
[Suggested wording]: Logins and passwords can now be exported to a CSV file.
[Links (documentation, blog post, etc)]: None yet. Andrei will work on a blog post for the Nightly blog.

Note we are hoping to also get CSV import (bug 1641777) in the same release and then we can combine the relnotes.

I have verified this issue using the latest Firefox Nightly 79.0a1 (Build ID: 20200604220012) on Windows 10 x64 1909, Ubuntu 18.04, Mac 10.14.6, Windows 7 x64, Windows 8.1 x32.

• The logins can be successfully exported to a CSV file using the "Export logins..." option from the menu.
• In order to verify this we have used the following scenarios:
  • Using a profile in which you are not logged in to Sync and have multiple logins saved.
  • Using a profile in which you are logged in to Sync and have many logins including breached and vulnerable accounts.

New SUMO article created for this: https://support.mozilla.org/en-US/kb/export-login-data-firefox-lockwise

This has been marked for localization for the Firefox 78 release. Please let me know any edits, or feel free to directly edit the article itself in SUMO.

(In reply to Angela Lazar from comment #61)

This has been marked for localization for the Firefox 78 release.

Hello, thank you. This should be for Firefox 79 as it's marked firefox78: disabled

Some comments:

If you want to move your saved usernames and passwords to a different application
…
Delete this file when finished.

I think this document isn't covering the other main use case for exporting to a CSV: backing up their logins without the intention to use another password manager.

You will be prompted to enter your operating system password

If they have MP set up then it will ask for that instead.

Thanks again

(In reply to Matthew N. [:MattN] from comment #62)

(In reply to Angela Lazar from comment #61)

This has been marked for localization for the Firefox 78 release.

Hello, thank you. This should be for Firefox 79 as it's marked firefox78: disabled

Some comments:

If you want to move your saved usernames and passwords to a different application
…
Delete this file when finished.

I think this document isn't covering the other main use case for exporting to a CSV: backing up their logins without the intention to use another password manager.

You will be prompted to enter your operating system password

If they have MP set up then it will ask for that instead.

Thanks again

I have a revision pending review. See https://support.mozilla.org/en-US/kb/export-login-data-firefox-lockwise/history

Thanks Alice, I approved your revision.

Matt let me know if any further changes need to be made.

Alice's changes look good. Thanks

Added to the Beta79 relnotes.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #66)

Added to the Beta79 relnotes.

Ugh, sorry, you beat me to following up on this flag… can we remove it for now as we want to wait to promote it with import (bug 1303176) in Fx80? Sorry about that… we just decided last week to ship without promoting.

Removed, should be live in the next 15-20min.