Closed Bug 250291 Opened 20 years ago Closed 20 years ago

html messages: forward as inline not quoting headers or inserting "original message" header

Categories

(MailNews Core :: Composition, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sspitzer, Assigned: neil)

References

Details

(Keywords: regression, Whiteboard: fixed-aviary1.0)

Attachments

(1 file)

forward as inline not quoting headers for html messages. it seems to be working for plain text messages. note, the mozilla 1.7 and aviary 1.0 branches don't seem to be affected
for html message, I'm not seeing this text: -------- Original Message -------- Subject: abc ...
No longer blocks: 249882
Summary: forward as inline not quoting headers for html messages → html messages: forward as inline not quoting headers or inserting "original message" header
Was this fallout from bug 192557? Tomorrow's build should tell.
> Was this fallout from bug 192557? Tomorrow's build should tell. I've got neil's fix for bug 192557 and it doesn't fix this problem.
Sorry, I can't reproduce this in my build, the original message table is fine.
I see this symptom in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040710 For the plain cases -- text/plain, multipart/mixed with text/plain body, or multipart/alternative displayed as plain -- forwarding is as expected, with the separator, headers and message body and attachments. HTML cases -- text/html, multipart/related, multipart/alternative displayed as HTML, or multipart/mixed w/ text/html body -- when forwarded inline include only the body (with attachments or embedded images). Anyone seeing this under Linux or Mac? I assume there's no difference on those platforms...
Keywords: regression
OS: Windows XP → Windows 2000
The problem here is that mimedrft.cpp simply pastes the -- Original Message -- into the <HEAD> of the message, which is nonsense for HTML...
Actually it pastes it before the <HEAD>, getting it ignored completely.
Attached patch Proposed patch (deleted) — Splinter Review
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #152960 - Flags: superreview?(bienvenu)
Attachment #152960 - Flags: review?(mscott)
Attachment #152960 - Flags: superreview?(bienvenu) → superreview+
Attachment #152960 - Flags: review?(mscott) → review+
Comment on attachment 152960 [details] [diff] [review] Proposed patch Trivial string text change to fix regression.
Attachment #152960 - Flags: approval1.8a2?
Comment on attachment 152960 [details] [diff] [review] Proposed patch a=sspitzer
Attachment #152960 - Flags: approval1.8a2? → approval1.8a2+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
verified.
Status: RESOLVED → VERIFIED
*** Bug 256028 has been marked as a duplicate of this bug. ***
fixed on the aviary 1.0 branch.
Whiteboard: fixed-aviary1.0
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: