Closed Bug 251099 Opened 20 years ago Closed 20 years ago

Update and Install buttons in Extension Manager not focusable

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bugs)

References

(Blocks 1 open bug)

Details

(Keywords: access, fixed-aviary1.0, Whiteboard: no l10n impact)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712
Firefox/0.9.1+

1. Open Extension Manager.
2. Press Tab a few times.

Result: "Uninstall" and "Update" never receive focus.

Accessibility impact: Ok for sighted keyboard-only users, who can use accesskeys
instead, but probably bad for blind users.

This is because of a "-moz-user-focus: ignore" in the default theme that should
not be there.  It might be there because the list view in that window relies on
nothing having focus, or it might be there because focus outlines are ugly on
those buttons.
Flags: blocking1.0mac?
Flags: blocking1.0mac? → blocking-aviary1.0?
Flags: blocking-aviary1.0? → blocking-aviary1.0+
"Get More Extensions" needs tabbability too.
Whiteboard: no l10n impact
Patch in bug 251098.
WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040901
Firefox/1.0 PR (NOT FINAL)

This issue has been fixed with Ben's recent changes to the window.  "Get More
..." is filed seperately as bug 251102.
Assignee: jruderman → bugs
Keywords: fixed-aviary1.0
I fixed this on the trunk and in some places Ben missed on aviary.  The aviary
version of the patch is in bug 251098.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
tested on linux fc2 (2004100809-0.9+) and mac os x 10.3.5 (2004100805-0.9+). I
cannot seem to move focus to either the Update or Uninstall buttons (Extensions
or Themes windows) by using the tab or arrow keys.

I can focus-and-activate when using the access keys/mnemonics, linux only. also,
I can move focus amongst the installed extensions/themes with the up/down
arrows, then open the context menu w/the keyboard (the latter nicely fixed in
bug 251098).

is there another issue which might be interfering here? (although on Mac, the
issue might actually be the one in bug 187508.)
Under Linux, it could be a theme issue.  What extension are you using? 
Gnomestripe, the default theme on Linux, doesn't have an extensions.css, which
could be relevant because this fix was in extensions.css.

I don't know why you wouldn't be able to tab to the buttons under Mac.
Status: RESOLVED → REOPENED
Keywords: fixed-aviary1.0
Resolution: FIXED → ---
sairuh was using a non-default theme on Linux.  I don't know what caused the Mac
issue (buttons still not in the tab order), but it's probably not this bug.
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.