User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1 When the install.rdf is malformed xpi package install fails without telling it was the RDF which is malformed. Reproducible: Always Steps to Reproduce: 1. Write an XPI install.rdf 2. add malformed element '<em:updateURL>http://myhost.com/update.rdf?pkgid=xxx&cid=yyy</em:updateURL>' 3. Make the .xpi file containing malformd install.rdf and try to open it with firefox Actual Results: Tells the package "[...] will only works with Firefox (null)" Expected Results: Telling that the package install manifest (install.rdf) is malformed and possibility telling what's wrong with that

-> firefox. there's no install.rdf in mozilla packages.

Patches are welcome... I believe you want to wrap http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#470 in a try/catch block and call showMalformedError() if the GetDataSourceBlocking call fails.

It's just ignoring the "bad" arc for me. If the manifest is severely broken, an error message is shown (but see bug 292854). Current behavior makes sense to me. It's not an excuse for Firefox not logging error messages appropriately, but extension authors can check their install.rdf using http://www.w3.org/RDF/Validator/ Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050428 Firefox/1.0+

Is this still an issue in the new update world?

(In reply to comment #5) No errors beside one in js console when extension is added to EM: Error: not well-formed Source File: file:///F:/ADMIN/install-1ww..rdf Line: 25, Column: 58 Source Code: '<em:updateURL>http://myhost.com/update.rdf?pkgid=xxx&cid=yyy</em:updateURL>' After restart chrome.manifest is empty / extension is not usable -> shouldn't been allowed to be installed ?. Also alert box would be rather better than error in js console. Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050716 Firefox/1.0+

The error in the JS console is from the XML parser itself and is not really suppressable. If you want a better error we're going to have to figure out a way to get the RDF service to hand a useful error back up the line from nsIRDFService.GetDataSource, which is not easy at all.

I got an alert when trying to install it stating that the extension was not compatible (e.g. incorrect error) and the message in the js console stating that the rdf was not well formed. This isn't something a user would normally see unless of course an extension author distributed an extension without trying to install it first. This should be fixed but isn't a priority.

Re: comment #7 - I'd be happy with an error being passed back up from the bowels of nsIRDFService that caused the top level to throw a dialog box "Malformed .rfd - see error console for details". Or does that code really not send back different return codes for "busticated" and "not compatible"?

Still an issue in the new Add-ons Manager.

Gven that add-ons are moving to WebExtensions and have no install.rdf, we'll close this bug.