Closed Bug 252759 Opened 20 years ago Closed 20 years ago

Crash when doing multiple advanced address book searches

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Stefan.Borggraefe, Assigned: Stefan.Borggraefe)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Attachments

(1 file, 1 obsolete file)

MailNews suffers from the same crash as TB did. See bug 251605.
Attached patch Port of the Thunderbird Fix (obsolete) (deleted) — Splinter Review
Attachment #154097 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 154097 [details] [diff] [review] Port of the Thunderbird Fix I think that the sort column and direction should be retained across searches. Checking against the message search, I notice that bienvenu broke it over a year ago - the indicators no longer appear :-(
Attachment #154097 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attached patch Hopefully better patch (deleted) — Splinter Review
Ok, this patch retains the sort order and fixes the crash. I tested the Address Book window itself, the Advanced Address Book Search dialog and the Select Addresses dialog with different profiles (including newly created profiles with no address book entries).
Attachment #154097 - Attachment is obsolete: true
Attachment #156134 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #156134 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #156134 - Flags: superreview?(mscott)
Attachment #156134 - Flags: superreview?(mscott) → superreview+
Comment on attachment 156134 [details] [diff] [review] Hopefully better patch Asking for approval. This fixes a crasher in the advanced address book search and makes sure the sort order of the columns is retained after a search operation. Should be pretty safe.
Attachment #156134 - Flags: approval1.8a3?
Comment on attachment 156134 [details] [diff] [review] Hopefully better patch a=asa for checkin to 1.8a3
Attachment #156134 - Flags: approval1.8a3? → approval1.8a3+
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 255973 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
Blocks: 239474
Depends on: 251605
Blocks: 260289
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: