User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040727 Firefox/0.9.1+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040727 Firefox/0.9.1+ In Prefs UI, left pane (with General, Privacy etc. buttons) steals focus from anything else if mouse hovers over it. There is completely no reason for this. Reproducible: Always Steps to Reproduce: 1. Tools -> options 2. Use keyboard or mouse to change focus to any widget in preferences window, or even any widget in other firefox window 3. Move mouse over left preferences pane It's even more visible in Pinball theme, where new Options window has focus on a button, and this focus unexpectely dissapears when you move a mouse (which means you don't have to do step 2 above to see weird behaviour). Actual Results: focus changed Expected Results: mouseover should not steal focus - at least it doesn't do that anywhere else, FF or windows or in other window managers The fix is easy: in browser.jar/content/browser/pref/pref.xul, line 88, the right pane is defined with onmouseover="focus();" Simply removing this restores the "expected" behaviour without any ill effects I could detect. Except one: The default theme "takes advantage of this" by ignoring the difference between focused buttons and mouseover-ed buttons, since any mouseover removes focus from them. This looks a bit weird, and can be fixed by the following change in classic.jar/skin/classic/browser/pref/pref.css: - .buttonBoxButton:hover, .buttonBoxButton:focus { - border: 1px solid; - -moz-border-left-colors: #98B4E2; - -moz-border-top-colors: #98B4E2; - -moz-border-right-colors: #98B4E2; - -moz-border-bottom-colors: #98B4E2; - background-color: #E0E8F6; - } + .buttonBoxButton:hover { + border: 1px solid; + -moz-border-left-colors: #98B4E2; + -moz-border-top-colors: #98B4E2; + -moz-border-right-colors: #98B4E2; + -moz-border-bottom-colors: #98B4E2; + background-color: #E0E8F6; + } + .buttonBoxButton:focus { + border: 1px solid; + -moz-border-left-colors: #98B4E2; + -moz-border-top-colors: #98B4E2; + -moz-border-right-colors: #98B4E2; + -moz-border-bottom-colors: #98B4E2; + } which doesn't change behaviour for "mouseover" buttons, but makes focused buttons have a border only, without background change (which is perfectly consistent with all other "focused" indications. And looks very good too, IMHO of course). I do not have the CVS source so I can't make a diff. However, if you agree with the change and need a diff, I probably am able to create one. Please advise.

I can confirm this behaviour on MacOS X, using the following builds: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040726 Firefox/0.9.1+ Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040720 Firefox/0.9.1+ Changing to HW/OS All/All and confirming.

Diffed against Aviary (Should be). Patch is exactly as described in initial comment, I take no credit other than making the patch itself.

Comment on attachment 154548 [details] [diff] [review] Described Fix r+sr?

Comment on attachment 154548 [details] [diff] [review] Described Fix >Index: mozilla/browser/themes/winstripe/browser/pref/pref.css >=================================================================== >RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/pref/pref.css,v >retrieving revision 1.1.2.1 >diff -d -u -8 -r1.1.2.1 pref.css >--- mozilla/browser/themes/winstripe/browser/pref/pref.css 5 Jun 2004 21:31:22 -0000 1.1.2.1 >+++ mozilla/browser/themes/winstripe/browser/pref/pref.css 28 Jul 2004 08:36:40 -0000 >@@ -54,25 +54,33 @@ > border: none !important; > } > > .buttonBoxButton > .button-box > .button-icon { > width: 32px; > height: 32px; > } > >-.buttonBoxButton:hover, .buttonBoxButton:focus { >+.buttonBoxButton:hover { > border: 1px solid; > -moz-border-left-colors: #98B4E2; > -moz-border-top-colors: #98B4E2; > -moz-border-right-colors: #98B4E2; > -moz-border-bottom-colors: #98B4E2; > background-color: #E0E8F6; > } > >+.buttonBoxButton:focus { >+ border: 1px solid; >+ -moz-border-left-colors: #98B4E2; >+ -moz-border-top-colors: #98B4E2; >+ -moz-border-right-colors: #98B4E2; >+ -moz-border-bottom-colors: #98B4E2; >+} >+ What's the point of duplicating this rule?

(In reply to comment #4) > What's the point of duplicating this rule? Button:focus does not have "background-color" entry - focused buttons have a border, but not dark background, like mouseovered buttons do. In my proof-testing having (of the focus patch), mouseovered buttons looking just like focused buttons gave me a feeling of something wrong - therefore, this skin patch (almost) restores the behaviour from before the "never have focus if mouse is involved" fix.

Comment on attachment 154548 [details] [diff] [review] Described Fix Please don't request approval until you've received necessary reviews. Thanks.

This is no longer relevant with new preferences window. Marking WFM.

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change