Closed
Bug 253693
Opened 20 years ago
Closed 20 years ago
Cmd+? should bring up Help Contents
Categories
(Firefox :: Keyboard Navigation, defect, P2)
Tracking
()
RESOLVED
FIXED
Firefox1.5
People
(Reporter: steffen.wilberg, Assigned: asaf)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
This is a split-up from bug 251165, which introduced F1 for Windows/Linux.
I also introduced VK_HELP on Mac in that bug, but that didn't work, see bug 252750.
So VK_HELP doesn't work currently. That's bug 124393.
Maybe we should use Cmd+? instead, which has been suggested in bug 88739 comment
76, but that doesn't work either. That's bug 253680.
|
Reporter | |
Updated•20 years ago
|
Flags: blocking-aviary1.0PR?
|
||
Updated•20 years ago
|
Flags: blocking-aviary1.0mac?
Flags: blocking-aviary1.0mac+
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0PR-
|
Assignee | |
Updated•20 years ago
|
Assignee: steffen.wilberg → bugs.mano
|
|
Reporter | |
Comment 1•20 years ago
|
||
VK_HELP finally works with bug bug 252750 fixed (which still needs checkin to
the 1.7-branch).
So this bug can be reduced to Cmd+?. Bug 253680 tries to make VK_HELP being
triggered by Cmd+?, but also has info about why |key="?" modifiers="accel"|
doesn't work.
I'm leaving this bug open because it already has blocking1.0mac+.
No longer depends on: 124393
Summary: Help key or Cmd+? should bring up Help Contents → Cmd+? should bring up Help Contents
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0mac+
Target Milestone: --- → Firefox1.1
|
|
Assignee | |
Updated•20 years ago
|
Flags: blocking-aviary1.0PR-
Priority: -- → P2
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 179100 [details] [diff] [review]
patch
>+# ...Map Cmd+Shit+/, show Cmd+?
lol, thanks Steffen :)
|
||
Comment 4•20 years ago
|
||
Comment on attachment 179100 [details] [diff] [review]
patch
Ok, this looks right, but over to our resident Mac guy to sign off on this,
because as a non-Mac guy this seems just plain wrong.
Attachment #179100 -
Flags: superreview+
Attachment #179100 -
Flags: review?(mconnor)
Attachment #179100 -
Flags: review?(joshmoz)
Attachment #179100 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #179100 -
Flags: approval-aviary1.1a?
|
||
Comment 5•20 years ago
|
||
Comment on attachment 179100 [details] [diff] [review]
patch
a=asa
Attachment #179100 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
|
|
Assignee | |
Comment 6•20 years ago
|
||
Attachment #179100 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•20 years ago
|
||
Checking in base/content/baseMenuOverlay.xul;
/cvsroot/mozilla/browser/base/content/baseMenuOverlay.xul,v <--
baseMenuOverlay.xul
new revision: 1.4; previous revision: 1.3
done
Checking in locales/en-US/chrome/browser/baseMenuOverlay.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd,v <--
baseMenuOverlay.dtd
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•