When defining scheduled whine events, add groups of users as targets of a whine. Each will still get the report run under his own permissions, but a single event schedule can cover a whole list of people. In the same update, the use of group pronouns in whining should be permitted if EITHER the recipient ("user" param to Search.pm) or the author (need a new optional "author" param to Search.pm) has permission to reference the group pronoun.

Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004. Anything flagged enhancement that hasn't already landed is being pushed out. If this bug is otherwise ready to land, we'll handle it on a case-by-case basis, please set the blocking2.20 flag to '?' if you think it qualifies.

Okay, here it is! This patch adds group targets for whining, but I snuck in a couple of other things. The first thing I did was fix the problem that was reported on bug 185090 after it was closed, where changes to schedules were not working unless the day/time of the schedule was altered. It's a trivial enough change that I figured I could be a schmuck and roll it in. I can break it out and put it into a 3-line patch somewhere else if I need to. I cleaned up a small amount of the existing code to make it more readable. Some of those '$_->[0]'s were getting on my nerves. Last, I broke Joel's ValidateGroupName function out of Search.pm and added a new file, Group.pm, for group manipulation functions. I only put the one function in for now, but I'm sure later on it'll have more. Dave: I'm going to request blocking2.20 on this because it fixes a fairly major bug, and I believe any differences in whining between 2.19.1 and 2.20 won't really hurt anyone, but I'm willing to be argued with on that.

yeah, why not. It's big enough I want to hold it, but on the other hand, it is one of our advertised major new features, so we might as well have it working completely and correctly from the get-go.

/me drools I need the second review on here before I approve it, but leaving it in the queue as it's more likely I'll see it that way :) I'll come back to this tomorrow when I have time to play.

Comment on attachment 170285 [details] [diff] [review] whine at groups OK, this fails to apply cleanly, but the two conflicts are places where things were added to the same place. Procedure to unbitrot this: cvs -q up -dP -D2005-01-04 patch -p0 < whineatgroups.patch cvs -q up -AdP then edit checksetup.pl and Bugzilla/Constants.pm and just remove the conflict markers (note that there's two sets of markers in Constants.pm). You might want to update the date in the comment in checksetup.pl on checkin as well.

Note to travis: let Erik do the checkin on this please. :)

Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.347; previous revision: 1.346 done Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.49; previous revision: 1.48 done Checking in editwhines.cgi; /cvsroot/mozilla/webtools/bugzilla/editwhines.cgi,v <-- editwhines.cgi new revision: 1.3; previous revision: 1.2 done Checking in whine.pl; /cvsroot/mozilla/webtools/bugzilla/whine.pl,v <-- whine.pl new revision: 1.7; previous revision: 1.6 done Checking in Bugzilla/Constants.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v <-- Constants.pm new revision: 1.18; previous revision: 1.17 done Checking in Bugzilla/Search.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm new revision: 1.78; previous revision: 1.77 done Checking in template/en/default/whine/schedule.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/schedule.html.tmpl,v <-- schedule.html.tmpl new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v done Checking in Bugzilla/Group.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v <-- Group.pm initial revision: 1.1 done