Closed
Bug 254952
Opened 20 years ago
Closed 20 years ago
make MIMEService/MIMEInfo-users make use of UTF-8 extensions
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha4
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
turns out I forgot to check callers in bug 80787... at least webbrowserpersist
uses ToNewUnicode(ext) but should use UTF8ToNewUnicode:
http://lxr.mozilla.org/seamonkey/source/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp#1290
Assignee | ||
Updated•20 years ago
|
Assignee: file-handling → cbiesinger
Assignee | ||
Comment 1•20 years ago
|
||
there are some places which really ignore charsets currently, and I didn't want
to touch them, so this patch only fixes two callers.
Assignee | ||
Updated•20 years ago
|
Attachment #157547 -
Flags: superreview?(darin)
Attachment #157547 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha4
Comment 2•20 years ago
|
||
Comment on attachment 157547 [details] [diff] [review]
patch
r=bzbarsky
Attachment #157547 -
Flags: review?(bzbarsky) → review+
Updated•20 years ago
|
Attachment #157547 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Comment 3•20 years ago
|
||
Checking in embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp,v
<-- nsWebBrowserPersist.cpp
new revision: 1.97; previous revision: 1.96
done
Checking in mailnews/mime/src/mimemoz2.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimemoz2.cpp,v <-- mimemoz2.cpp
new revision: 1.210; previous revision: 1.209
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 4•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040901
Firefox/1.0 PR (NOT FINAL)
I'm getting pretty /tired/ of watching <?> 's i/o é ä etc all the time and
having to manually force FF to use whatever charset the page needs.
Could this go to branch too please.
Assignee | ||
Comment 5•20 years ago
|
||
(In reply to comment #4)
> I'm getting pretty /tired/ of watching <?> 's i/o é ä etc all the time and
> having to manually force FF to use whatever charset the page needs.
I think you are misunderstanding what the patch does. it does not address
display of pages. it affects file extensions in a few cases.
Comment 6•20 years ago
|
||
thanks for explaining
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•