Closed
Bug 255113
Opened 20 years ago
Closed 20 years ago
"Bookmark this Link" should be "Bookmark This Link..."
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox1.0beta
People
(Reporter: bugzilla, Assigned: steffen.wilberg)
References
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file)
(deleted),
patch
|
steffen.wilberg
:
review+
steffen.wilberg
:
approval-aviary+
|
Details | Diff | Splinter Review |
To be consistent with links on a webpage.
Updated•20 years ago
|
Summary: "Bookmark this Link" should be "Bookmark This Link..." → "Bookmark This Link" should be "Bookmark This Link..."
Comment 1•20 years ago
|
||
Comment 2•20 years ago
|
||
Comment on attachment 155990 [details] [diff] [review]
Patch
Patch is simple...will request blocking-aviary1.0? in a sec because it's a l10n
issue.
Attachment #155990 -
Flags: review?(firefox)
Updated•20 years ago
|
Flags: blocking-aviary1.0PR?
OS: Windows XP → All
Hardware: PC → All
Updated•20 years ago
|
Whiteboard: [have patch]
Reporter | ||
Comment 3•20 years ago
|
||
Steffen, can you check this in please?
Assignee: firefox → steffen.wilberg
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 155990 [details] [diff] [review]
Patch
Noting r/a=blake.
"This" needs to capitalized, in accordance with the Gnome and MS HIG, and with
the menu items in the Bookmarks and the context menu, as well as "Find in This
Page...".
http://developer.gnome.org/projects/gup/hig/2.0/design-text-labels.html#layout-
capitalization
Attachment #155990 -
Flags: review?(firefox)
Attachment #155990 -
Flags: review+
Attachment #155990 -
Flags: approval-aviary+
Assignee | ||
Comment 5•20 years ago
|
||
Checked in br & trunk 2004-08-22 02:29.
Severity: normal → trivial
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Summary: "Bookmark This Link" should be "Bookmark This Link..." → "Bookmark this Link" should be "Bookmark This Link..."
Whiteboard: [have patch]
Target Milestone: --- → Firefox1.0beta
Component: History → Bookmarks & History
QA Contact: mozilla → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•