Closed Bug 255803 Opened 20 years ago Closed 19 years ago

update website needs to handle version numbers correctly

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 304857

People

(Reporter: bugs, Assigned: morgamic)

References

Details

The version strings stored in varchar(10)s in Version, MinAppVer, MaxAppVer are treated as decimals by various functions in update.mozilla.org code. Instead, they should be treated as Firefox Version Format strings, which requires some special parsing and analysis. See http://lxr.mozilla.org/aviarybranch/source/toolkit/mozapps/extensions/service/Version.java
Flags: blocking-aviary1.0PR+
Priority: -- → P1
Blocks: 255800
Status: NEW → ASSIGNED
No longer blocks: 255800
Status: ASSIGNED → NEW
any progress on this one? how critical is this for holding up the initial PR push?
Whiteboard: [server side]
(In reply to comment #1) I wouldn't hold PR for this, as its pretty much stalled. The "functions" in Update code that don't parse the string properly are part the MySQL query strings. MySQL itself doesn't seem to have string functions suitable to resolve this bug. That I've found in the MySQL 4.x manual. I haven't found another way to do this either. (having PHP parse it, as Ben has had Java do in the link provided, would require returning the whole list each time, I'm pretty sure. which is unacceptable, IMO).
Whiteboard: [server side] → [server side] fixed by switch to rdf?
OK.
Flags: blocking-aviary1.0PR+ → blocking-aviary1.0PR-
Whiteboard: [server side] fixed by switch to rdf?
Priority: P1 → --
*** Bug 263994 has been marked as a duplicate of this bug. ***
Depends on: 264970
*** Bug 264970 has been marked as a duplicate of this bug. ***
No longer depends on: 264970
There are several bugs that relate to the sorting of versions being incorrect. I suggest that we correct this by having columns for major, minor, subver, and build, like we do for t_applications. This would be more correct than Date Updated because someone can add/edit an older version. This will not only require a db change, but some php to change when inserting the record and querying. RSS and XML export are dependent.
Blocks: 247008, 262153
Date Updated isn't what's used.
Assignee: psychoticwolf → nobody
Whiteboard: after-1.0
Bulk Moving Developer Control Panel bugs to new component. (Filter: massdevcpspam)
Component: Update → Developers
Product: mozilla.org → Update
Version: other → unspecified
Blocks: 271268
Flags: blocking-aviary1.0PR-
Severity: normal → major
Whiteboard: after-1.0
Target Milestone: --- → 1.1
Target Milestone: 1.1 → 2.0
Blocks: 292138
Depends on: 304857
Assignee: nobody → morgamic
*** This bug has been marked as a duplicate of 304857 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
No longer depends on: 304857
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.