Closed
Bug 256284
Opened 20 years ago
Closed 20 years ago
Remove duplicate strings from downloads.properties
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
VERIFIED
FIXED
mozilla1.7.4
People
(Reporter: dean_tessman, Assigned: Waldo)
Details
(Keywords: fixed-aviary1.0)
The fix for bug 238571 changed four strings to all have the same text. We can
narrow this down to one. Jeff created a patch over there (attachment 156436 [details] [diff] [review]) to
do just that. His patch saves some bytes. Not only does it remove three of the
four strings, but it also removes that platform-specific ifdefs that retrieved
the proper string.
|
Reporter | |
Comment 1•20 years ago
|
||
This would need to get in for the PR, since it affects localization.
Flags: blocking-aviary1.0PR?
|
||
Comment 2•20 years ago
|
||
renominate if a fix becomes available. trying to shut down to get PR shipped...
thanks
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR-
|
|
Reporter | |
Comment 3•20 years ago
|
||
There is a fix. See comment 0 - it's attached to bug 238571.
Flags: blocking-aviary1.0PR- → blocking-aviary1.0PR?
|
||
Updated•20 years ago
|
Whiteboard: [has patch] in bug 238571
|
|
||
Comment 4•20 years ago
|
||
ok, so lets track in bug 238571. that one is plussed for PR right now.
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR-
|
|
Reporter | |
Comment 5•20 years ago
|
||
Can you give the patch approval-aviary+, then?
|
Assignee | |
Comment 6•20 years ago
|
||
This was fixed a few days back by Ben.
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [has patch] in bug 238571
Target Milestone: --- → Firefox1.0beta
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•