Closed
Bug 256963
Opened 20 years ago
Closed 20 years ago
document.all warning doesn't show in Firefox JS console, dom.properties not loaded
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: me, Assigned: bugzilla)
References
Details
(Keywords: fixed-aviary1.0, Whiteboard: see comment 7)
Attachments
(3 files)
(deleted),
text/html
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
benjamin
:
review+
brendan
:
superreview+
brendan
:
approval-aviary+
|
Details | Diff | Splinter Review |
The document.all warning message doesn't show in the JS console in Firefox. I assume this is because in Firefox, dom.properties is at: chrome://global/locale/dom/dom.properties but the backend is attempting to load it from: chrome://communicator/locale/dom/dom.properties http://lxr.mozilla.org/aviarybranch/source/content/base/src/nsDocumentViewer.cpp#205 http://lxr.mozilla.org/aviarybranch/source/dom/src/base/nsDOMClassInfo.cpp#348 Presumably the other warnings in dom.properties are never shown either, though I haven't tested it. Requesting blocking 1.0PR (don't know if this will affect localizers or not) Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.2) Gecko/20040825 Firefox/0.9.1+
In Mozilla a warning appears in the console, in Firefox nothing happens.
Comment 3•20 years ago
|
||
include use of global reference. Should show: Warning: Non-standard document.all property was used. Use W3C standard document.getElementById() instead. Source File: file:///C:/temp/documentAll.html Line: 9 Warning: Element referenced by ID/NAME in the global scope. Use W3C standard document.getElementById() instead. Source File: file:///C:/temp/documentAll.html Line: 10
Comment 4•20 years ago
|
||
Updated•20 years ago
|
Attachment #157572 -
Flags: superreview?(brendan)
Attachment #157572 -
Flags: review?(bsmedberg)
Comment 5•20 years ago
|
||
Comment on attachment 157572 [details] [diff] [review] Fix chrome URI to the dom.properties file This should be fixed for PR1
Attachment #157572 -
Flags: approval-aviary?
Updated•20 years ago
|
Attachment #157572 -
Flags: review?(bsmedberg) → review+
Comment 6•20 years ago
|
||
Comment on attachment 157572 [details] [diff] [review] Fix chrome URI to the dom.properties file 1.7 branch merge later, eh? /be
Attachment #157572 -
Flags: superreview?(brendan)
Attachment #157572 -
Flags: superreview+
Attachment #157572 -
Flags: approval-aviary?
Attachment #157572 -
Flags: approval-aviary+
Comment 7•20 years ago
|
||
Fixed on the aviary branch. Leaving bug open to figure out if this is needed on the trunk and/or the 1.7 branch too.
Comment 8•20 years ago
|
||
removing blocking? as this is fixed on aviary branch
Flags: blocking-aviary1.0PR?
Whiteboard: see comment 7
Comment 9•20 years ago
|
||
This is not needed on the trunk or 1.7 branch. I have not centralized the gecko locale files on the trunk yet, pending announcements/reviews in bug 256188. I would sure love some module owner approvals there ;)
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•