Closed Bug 257303 Opened 20 years ago Closed 20 years ago

lastused in logincookies should not have type timestamp

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.20

People

(Reporter: Tomas.Kopal, Assigned: Tomas.Kopal)

References

Details

Attachments

(1 file, 2 obsolete files)

V3 of the patch
(deleted), patch
goobix
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040820 Debian/1.7.2-4 Build Identifier: As discussed in bug 156834, timestamp type should be replaced by datetime. This bug is against a lastused column in logincookies table. Patch will follow. Reproducible: Always Steps to Reproduce:
Blocks: 156834
Attached patch Patch to replace timestamp with datetime type (obsolete) (deleted) — — Splinter Review
Attachment #157305 - Flags: review?
Attached patch Newer version of the patch (obsolete) (deleted) — — Splinter Review
Updated checksetup.pl change to use existing function.
Attachment #157305 - Attachment is obsolete: true
Attachment #157319 - Flags: review?
Attachment #157305 - Flags: review? → review-
Attachment #157319 - Flags: review? → review+
Link for the MySQL documentation: http://dev.mysql.com/doc/mysql/en/DATETIME.html
Assignee: justdave → Tomas.Kopal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
Attached patch V3 of the patch (deleted) — — Splinter Review
Minor change in checksetup.pl to avoid annoying messages on every run, even when the type does not actually change.
Attachment #157319 - Attachment is obsolete: true
Comment on attachment 157555 [details] [diff] [review] V3 of the patch Sorry about changing this after review, but I tought it better be fixed.
Attachment #157555 - Flags: review?(vladd)
Waiting for review of v3 before approving.
Attachment #157555 - Flags: review?(vladd) → review+
Flags: approval? → approval+
Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.302; previous revision: 1.301 done Checking in Bugzilla/Auth/Login/WWW/CGI.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v <-- CGI.pm new revision: 1.3; previous revision: 1.2 done Checking in Bugzilla/Auth/Login/WWW/CGI/Cookie.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI/Cookie.pm,v <-- Cookie.pm new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: