Closed Bug 257739 Opened 20 years ago Closed 20 years ago

[ATK] Can't read the title name of windows/dialogs

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: Louie.Zhao, Assigned: pkwarren)

References

Details

(Keywords: access, Whiteboard: sunport17)

Attachments

(1 file, 1 obsolete file)

Patch v2
(deleted), patch
aaronlev
: review+
jst
: superreview+
Details | Diff | Splinter Review
The top-level window of mozilla has no accessible name, which prevents gnopernicus to read the name of window/dialog. This is very important for blind user to switch between different window/dialog.
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
In order to support getting window name, the patch adds "GetTitle" in nsIWidget. nsWindow.cpp on different platforms should "implement" this interface. This patch only does it for gtk2 and returns NS_ERROR_NOT_IMPLEMENTED on other platforms.
Attachment #157691 - Flags: review?(aaronleventhal)
Comment on attachment 157691 [details] [diff] [review] patch v1 >+ NS_IMETHOD GetTitle(PRUnichar** aTitle); > NS_IMETHOD SetTitle(const nsAString& aTitle); would you please think about what you're doing? ask yourself "why am I making the getters and setters handle different types?" and please cc the platform owners, especially tier-1, but be nice and cc tier-3 too.
Attachment #157691 - Flags: review?(aaronleventhal) → review-
> would you please think about what you're doing? ask yourself "why am I making > the getters and setters handle different types?" Timeless, please learn some social skills. That was quite rude and unnecessary. Just stick to the facts in a nice way.
Assignee: aaronleventhal → Louie.Zhao
Blocks: 263575
Whiteboard: sunport17
Assignee: Louie.Zhao → pkwarren
Status: NEW → ASSIGNED
Attached patch Patch v2 (deleted) — — Splinter Review
- Instead of pushing GetTitle all the way down to nsIWidget, save the title in nsXULWindow and return it there. This saves us from having to implement this method for all of the widget platforms.
Attachment #157691 - Attachment is obsolete: true
Attachment #170938 - Flags: review?(aaronleventhal)
Attachment #170938 - Flags: superreview?(jst)
Attachment #170938 - Flags: review?(aaronleventhal)
Attachment #170938 - Flags: review+
Comment on attachment 170938 [details] [diff] [review] Patch v2 sr=jst
Attachment #170938 - Flags: superreview?(jst) → superreview+
Patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Why couldn't you use the title from the XUL document?
Neil, which method would work better for the embedded Gecko HTML control scenario?
Well, my wild guess would be that embedding wouldn't use nsXULWindow...
Louie, does this work for embedded Gecko windows where the chrome is GTK, such as in Galeon? Apparently not, as Neil points out that nsIBaseWindow is implemented by nsXULWindow. Do we need to reopen? Neil, I don't think your suggestion of using nsXULDocument will help with that scenario.
Sorry, I didn't mean it as nsXULDocument but nsIDOMNSDocument or nsIDocument.
I am investigating this and try to use nsIDOMNSDocument instead of nsXULWindow if embedded Gecko can't work with it. I will reopen (or file a new bug) to fix it.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: