Closed
Bug 258158
Opened 20 years ago
Closed 20 years ago
Should not require JavaScript to show the version in about:
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha4
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
benjamin
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Instead, the preprocessor can be used. This also makes the info more reliable if
the useragent is spoofed.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #158002 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #158002 -
Flags: review?(caillon)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha4
|
|
Assignee | |
Comment 3•20 years ago
|
||
didn't notice that bug; but about: will still not show the useragent, so that's
one more issue for that bug.
Blocks: 91779
|
|
Assignee | |
Comment 4•20 years ago
|
||
Comment on attachment 158002 [details] [diff] [review]
patch
I'll add an entity to brand.dtd instead
Attachment #158002 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #158002 -
Flags: review?(caillon)
Attachment #158002 -
Flags: review-
|
|
Assignee | |
Comment 5•20 years ago
|
||
Attachment #158002 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•20 years ago
|
Attachment #158006 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #158006 -
Flags: review?(caillon)
|
||
Updated•20 years ago
|
Attachment #158006 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
|
||
Comment 6•20 years ago
|
||
Comment on attachment 158006 [details] [diff] [review]
patch v2
It is not acceptable to code version numbers into locale files, since you can
use the same langpack for 1.7, 1.7.1, 1.7.2, etc. I just fixed this for
firefox, see bug 257592
Attachment #158006 -
Flags: review?(caillon) → review-
|
|
Assignee | |
Comment 7•20 years ago
|
||
ok then, this patch creates a new version.dtd in global/content, which contains
the current version number.
|
|
Assignee | |
Updated•20 years ago
|
Attachment #158006 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•20 years ago
|
Attachment #158732 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #158732 -
Flags: review?(bsmedberg)
|
|
||
Updated•20 years ago
|
Attachment #158732 -
Flags: review?(bsmedberg) → review+
|
|
||
Updated•20 years ago
|
Attachment #158732 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
|
|
Assignee | |
Comment 8•20 years ago
|
||
Checking in jar.mn;
/cvsroot/mozilla/xpfe/global/jar.mn,v <-- jar.mn
new revision: 1.76; previous revision: 1.75
done
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/version.dtd,v
done
Checking in resources/content/version.dtd;
/cvsroot/mozilla/xpfe/global/resources/content/version.dtd,v <-- version.dtd
initial revision: 1.1
done
Checking in resources/locale/en-US/about.xhtml;
/cvsroot/mozilla/xpfe/global/resources/locale/en-US/about.xhtml,v <-- about.xhtml
new revision: 1.24; previous revision: 1.23
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
|
|
Assignee | |
Comment 9•19 years ago
|
||
*** Bug 314391 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•