Closed Bug 258995 Opened 20 years ago Closed 20 years ago

Able to upload item with wrong GUID

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Bugzilla-alanjstrBugs, Assigned: wolf)

References

Details

(Whiteboard: beta)

If you are uploading an Update, select from the radio buttons but don't pick the right one in the dropdown, it seems that it will create the entry with an ID of the wrong theme. For example, if I upload Doodle, but leave the dropdown on 708, it will create a new version of 708. If, as an author, I have 10 themes, this could get messy. Shouldn't we detect a GUID mismatch?
Yeah, mismatch should be detected, although the author should definitally be allowed to change the UID for their theme/extension.
Yeah, the mismatch should be.. Under what conditions would an author be allowed to change the UID though?
If for example an author used someone elses code as a template, then submited the extension, you'd have a problem. This could happen to extensions that aren't listed on U.M.O like TBE or Spellbound as examples. Or even the same author who has various extensions. As long as it's easy for the authors to delete one of their listings easily then perhaps this is not an issue (although the mismatch still is). just my 2 cents
In theory, that situation doesn't create a "we need to allow a change in GUID" case. That theme or extension should be rejected entirely. GUID/Author mismatch. As it'd also cause problems in Firefox that can't be solved by fiddling with DB data.
Status: NEW → ASSIGNED
Whiteboard: fixed-development
This affects extensions too. Modifiying summary.
Summary: Able to upload theme with wrong GUID → Able to upload item with wrong GUID
Whiteboard: fixed-development
As the add process now cares about the GUID and doesn't blindly believe the drop-down, this is fixed for non-legacy extensions/themes. Legacy items, it's basically not possible to fix. As there's no way to know what the file is in an intelligent manner.
Whiteboard: fixed-development
In which case do we still provide a dropdown? Does that dropdown show those that we have a GUID for, or just those we do not? What if someone adds a GUID to a legacy? How will that be handled?
Whiteboard: fixed-development → fixed-beta
Blocks: 246945
Bulk Moving Developer Control Panel bugs to new component. (Filter: massdevcpspam)
Component: Update → Developers
Product: mozilla.org → Update
Version: other → unspecified
Mass-resolving bugs that have been fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Sorry for the bugspam, reopening bugs wrongly marked as resolved.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Target Milestone: --- → 1.0
Status: ASSIGNED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
Whiteboard: fixed-beta → beta
Version: unspecified → 0.9
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.