If you open a folder with a flat sort, e.g., by date, and then click the thread icon, there can be various display and selection anomalies. Some messages are showed indented under messages that are not their parents; selecting what looks like a thread can select more messages than appear in the thread, etc. This is a regression from bug 243281 - I'm not sure why that code doesn't work, but I have a patch that fixes it.

the problem was that the levels array had non-zero entries in it, and we were leaving those alone. I think the reason that was broken was because nsMsgDBView::Sort doesn't touch the levels array, so it gets out of sync with the keys and flags array. Another fix would be to just zero out the levels array up front - I'll test that out...

this is simpler, and nearly as efficient as zeroing out the array all at once.

Comment on attachment 158980 [details] [diff] [review] proposed fix making sure this is OK with Neil, since it's his optimization I'm mucking with :-)

fixed, r=neil, sr=sspitzer over aim

Comment on attachment 158980 [details] [diff] [review] proposed fix clearing out my review reqeust since this has been fixed

Comment on attachment 158980 [details] [diff] [review] proposed fix plusing for Neil (r=over aim)