Closed Bug 259890 Opened 20 years ago Closed 20 years ago

don't call Remove(PR_TRUE) to delete a file

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha4

People

(Reporter: Biesinger, Assigned: Biesinger)

References

Details

(Keywords: fixed-aviary1.0, fixed1.7.5)

Attachments

(2 files)

patch
(deleted), patch
bzbarsky
: review+
darin.moz
: superreview+
dveditz
: approval-aviary+
dveditz
: approval1.7.5+
Details | Diff | Splinter Review
Aviary 1.0 port
(deleted), patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/nsExternalHelperAppService.cpp#2226 I'd prefer to pass PR_FALSE here, to be absolutely certain that this will not blow away an entire directory
Attached patch patch (deleted) — — Splinter Review
Attachment #159127 - Flags: superreview?(darin)
Attachment #159127 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha4
Attachment #159127 - Flags: superreview?(darin) → superreview+
Comment on attachment 159127 [details] [diff] [review] patch r=bzbarsky
Attachment #159127 - Flags: review?(bzbarsky) → review+
Checking in uriloader/exthandler/nsExternalHelperAppService.cpp; /cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v <-- nsExternalHelperAppService.cpp new revision: 1.269; previous revision: 1.268 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 159127 [details] [diff] [review] patch see bug 259708 for an example of where this bites badly. i think we should get this patch on the branches as a safety measure at least even though bug 259708 should probably be fixed at a higher level.
Attachment #159127 - Flags: approval1.7.x?
Attachment #159127 - Flags: approval-aviary?
Comment on attachment 159127 [details] [diff] [review] patch a=dveditz for 1.7x
Attachment #159127 - Flags: approval1.7.x? → approval1.7.x+
Comment on attachment 159127 [details] [diff] [review] patch a=dveditz for aviary as well, I'm not actually endowed but this is a no-brainer given safety plus blocking bug 259708
Attachment #159127 - Flags: approval-aviary? → approval-aviary+
Callek says attachment 159127 [details] [diff] [review] will not apply to Firefox trunk. It looks like the contextual code is quite different.
Comment on attachment 160032 [details] [diff] [review] Aviary 1.0 port r+sr=bzbarsky on this patch, fwiw.
Attachment #160032 - Flags: superreview+
Attachment #160032 - Flags: review+
Comment on attachment 160032 [details] [diff] [review] Aviary 1.0 port <bz> You can just unset the approval requests; the a=dveditz applies. <bz> Since biesi's patch is approved for both.
Attachment #160032 - Flags: approval1.7.x?
Attachment #160032 - Flags: approval-aviary?
setting blocking flags to assist in getting checkin of ported patch to aviary and 1.7.x stable branch.
Flags: blocking1.7.x?
In on aviary and 1.7.x.
Flags: blocking1.7.x?
Flags: blocking-aviary1.0?
Keywords: fixed-aviary1.0
> Callek says attachment 159127 [details] [diff] [review] will not apply to Firefox trunk. surely you meant branch here? because this code is not forked by firefox. adding fixed1.7.x keyword (checkin by vlad, 2004-09-24 21:58). thanks for doing the checkin for me. also, I'm not sure that this actually fixes bug 259708. please test.
Keywords: fixed1.7.x
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: