Christopher Aillon (sabbatical, not receiving bugmail) Assignee
	Comment 2 • 20 years ago

Comment on attachment 159639 [details] [diff] [review]
Patch

Er, ignore the get_type stuff.	That was stuff I tried to get rid of the 64 bit
crasher with.

Anyway, this fixes the warning about the GdkWIndow invalid cast (and properly
parents the file chooser!), does some cleanup on the code to parse the filters,
and also tries to make sure that the Gtk2 module factory gets to decide which
file picker implementation to use when called with the contractid by removing
the xul contractid.

	Christopher Aillon (sabbatical, not receiving bugmail) Assignee
	Comment 3 • 20 years ago

The code to cast here is a little better and should be more failsafe.

	Vaclav Dvorak
	Comment 4 • 20 years ago

Before I file yet another duplicate bug, does anyone know about the issue where
GTK2 builds of Mozilla don't ask for confirmation when saving a download over an
existing file?

	Christian :Biesinger (don't email me, ping me on IRC)
	Comment 5 • 20 years ago

(In reply to comment #4)
> GTK2 builds of Mozilla don't ask for confirmation when saving a download over an
> existing file?

bug 259220

	Brian Ryner (not reading)
	Comment 6 • 20 years ago

Comment on attachment 160265 [details] [diff] [review]
Better patch

>@@ -455,45 +477,20 @@ nsFilePicker::Show(PRInt16 *aReturn)
>                                          directory.get());
>   }
> 
>-  PRInt32 count = mFilters.Count();
>-  for (PRInt32 i = 0; i < count; ++i) {
>-    GtkFileFilter *filter = _gtk_file_filter_new ();
>-
>+  int count = mFilters.Count();

This should be PRInt32, that's what the nsVoidArray method returns.

>+  for (int i = 0; i < count; ++i) {

Same.

>+    char **patterns = g_strsplit(mFilters[i]->get(), ";", -1);
>+    if (!patterns) {
>+      return NS_ERROR_UNEXPECTED;
>     }

NS_ERROR_OUT_OF_MEMORY, perhaps?  Also, you need to free |patterns| with
g_strfreev().

r+sr=bryner with those fixed.

	Christopher Aillon (sabbatical, not receiving bugmail) Assignee
	Comment 7 • 20 years ago

This just got checked in

	Christopher Aillon (sabbatical, not receiving bugmail) Assignee
	Comment 8 • 20 years ago

This got checked in ages ago.