Closed Bug 261392 Opened 20 years ago Closed 13 years ago

Undo doesn't work for HTML paste

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: moz, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040914 Firefox/0.10 Build Identifier: Thunderbird version 0.8 (20040913) When I select some cells in OpenOffice.org 1.1.3, copy them and paste into Message Compose window, and I want to undo the action, the Undo dosen't work ever. Reproducible: Always Steps to Reproduce: 1. 2. 3.
WFM when pasting data from a plain text editor, from Word, or from a browser (Mozilla or Opera), with Win2K. Do you see this only from OpenOffice data, or do other data sources have the same result?
Summary: Undo dosen't work for HTML copy/paste → Undo doesn't work for HTML paste
No response from reporter; =>WFM
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
I see the same problem pasting from MS Access 2002. I highlight a datasheet, or any rectangular group of cells, and copy and paste it into a mail message. It pastes as a formatted table. After pasting, the caret (typing cursor) jumps back to the top of the message compose area, and UNDO does not work. It may have something to do with table formatted data being pasted. Reopening.
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
(In reply to comment #3) > It may have something to do with table formatted data being pasted. I can't reproduce this when pasting data from my version of Excel (Office 95 -- the paste is done as multiple lines of text, not as a table); nor pasting table data from Word (Office 2000); nor when pasting in HTML table data copied from the browser. However, there are several bugs filed under the Core::Editor component about Undo not working for some table operations, including certain drag/drop and paste operations; perhaps this is a dupe of one of those.
OK! I'm trying out a Debian installation. This bug is easily reproduced, using TB 2a1-X11/0909, and OpenOffice 1.1.3.
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: message-compose
Assignee: mscott → nobody
Woo. Easily reproducible using OpenOffice 3 on a Mac, copying a spreadsheet into content of a message compose window and then the undo operation after that will fail. Nominating wanted-thunderbird3 to keep it on the radar. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090115 Lightning/1.0pre Shredder/3.0b2pre
Flags: wanted-thunderbird3?
OS: Linux → All
Hardware: x86 → All
Version: unspecified → Trunk
Attached image screenshot (deleted) —
Screenshot after pasting. Trying to undo, either via cmd-Z or menu operation Edit -> Undo, seems to do nothing. I don't think I noticed anything in the Error Console.
I can easily reproduce this by pasting anything from Firefox. I'm using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1pre) Gecko/20090714 Shredder/3.0b3pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5 Anything I copy in Firefox and paste into the body of a compose window cannot be undone. If I "Paste Without Formatting" then it works normally. Additionally, after pasting any HTML the cursor jumps to the beginning of the message body instead of the end of the pasted section.
I'm having the same problem as Daniel. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Reproducible on Mac OS X 10.6 using TB 3.0.1 and pasting from Firefox 3.5.8.
There is also the problem that after pasting the HTML text, the insertion point moves to the start of the email body area.
I experience this on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3. I am sure this didn't happen in Thunderbird 2. When I copy text from Windows Notepad, and press Paste in the Thunderbird compose area, I can undo. When I copy plain text from Microsoft Word 2007, and do the same, I can't undo. Like Dan above, I notice the strange relocation of the cursor. I tried to diagnose things a bit using clipbrd.exe (Windows XP clipboard viewer) and didn't notice anything on the clipboard classified as "HTML" in either case.
I have the same problem using thunderbird 3.1.1 or 3.1.2 (Mozilla/5.0 (X11; U; Linux i686 (x86_64); nl-NL; rv:1.9.2.8) Gecko/20100802 Lightning/1.0b2 Thunderbird/3.1.2) with or without plugins. Pasting plain text or pasting without formatting works fine. Pasting formatted text makes the cursor jump to the beginning of the message and then I cannot use the undo functionality. The undo option is available from the menu but both (ctrl-z + menu option) do not work. After typing some text after the paste I can undo till the paste.
(In reply to comment #16) > There is also the problem that after pasting the HTML text, the insertion point > moves to the start of the email body area. Same here (latest TB as released today, copying parts of a web page in Google Chrome to message compose window), this issue is almost more annoying than the broken undo.
The problem exists in Thunderbird 6.0 (Windows 7 sp1 32-bit).
Joe, can you hook this up with a matching bug from core, or elsewhere?
Seems a basic flaw/design problem, between editor and Dom manipulation. Bug 290261
indeed. let's keep this open in Thunderbird. perhaps also bug 471107
Depends on: 290261
This bug appears to be fixed as of Thunderbird 10.0.2 on Windows XP. I can paste complex HTML (including tables) from Firefox 10 and Internet Explorer 8 into the compose window, and both undo and redo work fine. Pasting the HTML also no longer permanently corrupts the formatting of the rest of the message. This is a huge time-saver for me and thanks to whoever fixed it.
(In reply to humbads from comment #25) > This bug appears to be fixed as of Thunderbird 10.0.2 on Windows XP. I can confirm on Mac -- Undo is working after pasting html-styled text and objects that were copied from Firefox or Chrome. (Selections copied in Safari paste in only as plain text but I'm guessing that's a Safari problem.) Mac OS 10.6.8, Thunderbird 10.0.2
Thanks for the updates. Does this also mean bug 290261 is gone? I doubt Peto is still around so closing based on comment 25 and 26.
Status: NEW → RESOLVED
Closed: 20 years ago13 years ago
Resolution: --- → WORKSFORME
Flags: wanted-thunderbird3?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: