Closed
Bug 261734
Opened 20 years ago
Closed 20 years ago
installer crashes given any commandline arguments
Categories
(Firefox :: Installer, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
References
Details
(Keywords: crash, fixed-aviary1.0)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ajschult784
:
review+
dveditz
:
superreview+
bryner
:
approval-aviary+
|
Details | Diff | Splinter Review |
if the installer is given any commandline arguments, it attempts to parse them
(ParseArgs) before calling ParseConfig, which sets up gCtx and loads the
resources. ParseArgs tries to use gCtx if any of the commandline arguments are
actually valid and the installer crashes.
Assignee | ||
Updated•20 years ago
|
Flags: blocking-aviary1.0?
Comment 1•20 years ago
|
||
betting that this might be an easy fix. if a patch appears renominate.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Assignee | ||
Comment 2•20 years ago
|
||
parse config before args
Assignee: bryner → ajschult
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #160427 -
Flags: review?(bryner)
Assignee | ||
Updated•20 years ago
|
Flags: blocking-aviary1.0- → blocking-aviary1.0?
Comment 3•20 years ago
|
||
Comment on attachment 160427 [details] [diff] [review]
patch
r=dveditz
How did this end up in the opposite order from the original version in
mozilla/xpinstall/wizard?
Attachment #160427 -
Flags: review?(bryner) → review+
Comment 4•20 years ago
|
||
Comment on attachment 160427 [details] [diff] [review]
patch
would be good to get bryner to look anyway just in case there was a reason for
changing this in the first place. Plus I realized I probably don't have r=
authority here anyway.
Attachment #160427 -
Flags: superreview?(bryner)
Comment 5•20 years ago
|
||
Comment on attachment 160427 [details] [diff] [review]
patch
I think the reason I reordered this is because gtk_init() needs to be called
before ParseConfig (because ParseConfig can call ErrorHandler which throws a
gtk dialog). I was giving ParseArgs a crack at the arguments before gtk, but
since I don't think there's any conflict there, it would probably be best to do
it in this order:
gtk_init
ParseConfig
ParseArgs
make sense?
Attachment #160427 -
Flags: superreview?(bryner) → superreview-
Assignee | ||
Comment 6•20 years ago
|
||
> gtk_init
> ParseConfig
> ParseArgs
>
> make sense?
this breaks the idea that silent mode shouldn't try to open the display.
in Seamonkey, I made the Errorhandler check if the display was open and (if not)
to print the message to the console
http://lxr.mozilla.org/mozilla/source/xpinstall/wizard/unix/src2/nsXInstaller.cpp#434
Comment 7•20 years ago
|
||
So, we could move gtk_init back to RunWizard, I guess, and bring over the fix to
print errors to the console if the display isn't [yet] open.
Comment 8•20 years ago
|
||
something like this
Updated•20 years ago
|
Attachment #160599 -
Flags: superreview?(dveditz)
Attachment #160599 -
Flags: review?(ajschult)
Assignee | ||
Comment 9•20 years ago
|
||
Comment on attachment 160599 [details] [diff] [review]
patch
looks good
Attachment #160599 -
Flags: review?(ajschult) → review+
Comment 10•20 years ago
|
||
ok, lets take this if we can get it in quick.
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Comment 11•20 years ago
|
||
Comment on attachment 160599 [details] [diff] [review]
patch
sr=dveditz
Attachment #160599 -
Flags: superreview?(dveditz) → superreview+
Updated•20 years ago
|
Attachment #160427 -
Attachment is obsolete: true
Updated•20 years ago
|
Attachment #160599 -
Flags: approval-aviary?
Comment 12•20 years ago
|
||
Comment on attachment 160599 [details] [diff] [review]
patch
i'm going to interpret comment 10 as approval.
Attachment #160599 -
Flags: approval-aviary? → approval-aviary+
Comment 13•20 years ago
|
||
checked in
Assignee | ||
Comment 14•20 years ago
|
||
*** Bug 264191 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → installer
You need to log in
before you can comment on or make changes to this bug.
Description
•