Closed Bug 262779 Opened 20 years ago Closed 20 years ago

[l10n] ExportedBookmarkFile text not localizable

Categories

(Camino Graveyard :: Translations, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino0.9

People

(Reporter: petteri.kamppuri, Assigned: Usul)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.2) Gecko/20040825 Camino/0.8.1 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.2) Gecko/20040825 Camino/0.8.1 Default file name, "ExportedBookmarkFile", for exporting bookmarks is not localizable. Reproducible: Always Steps to Reproduce: 1. Select Export Bookmarks from the File menu 2. See what the dialog box says. Expected Results: It should've given me a default localized version of the file name.
Confirming. In MainController.mm we have "int saveResult = [savePanel runModalForDirectory:nil file:NSLocalizedString(@"ExportedBookmarkFile", @"Exported Bookmarks")];" there is no such entry in localized.string Mike do you need a patch for this bug ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Also since we do bookmark stuff in 0.8.2 it would be nice if that one got included.
Attached file Corrected Localized strings (obsolete) (deleted) —
Attachment #161057 - Flags: review?(me)
Attachment #161057 - Flags: review?(joshmoz)
(In reply to comment #3) > Created an attachment (id=161057) > Corrected Localized strings > In your Localizable.strings you have: "Exported Bookmarks" = "ExportedBookmarkFile"; Shouldn't it be: "ExportedBookmarkFile" = "Exported Bookmarks";
Attachment #161057 - Flags: review?(me) → review-
Attachment #161057 - Flags: review?(joshmoz)
NeXT time I'll take my time before submiting.
Attachment #161057 - Attachment is obsolete: true
Attachment #161175 - Flags: review?(me)
Comment on attachment 161175 [details] Localized.strings containg the right string looks good to me
Attachment #161175 - Flags: superreview?(pinkerton)
Attachment #161175 - Flags: review?(me)
Attachment #161175 - Flags: review+
Target Milestone: --- → Camino0.9
Comment on attachment 161175 [details] Localized.strings containg the right string sr=pink. go for it.
Attachment #161175 - Flags: superreview?(pinkerton) → superreview+
Blocks: 261393
landed on trunk and MOZILLA_1_7_BRANCH
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: