Closed Bug 263689 Opened 20 years ago Closed 20 years ago

invalid URL opens new window despite tabbing preferences

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Version:
1.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.0

People

(Reporter: danm.moz, Assigned: danm.moz)

References

Details

(Keywords: fixed-aviary1.0)

Attachments

(3 files)

testcase
(deleted), text/html
Details
split new-tab and load-URI to allow proper return on URI load error
(deleted), patch
Details | Diff | Splinter Review
get proper return on URI load error and initialize referrer
(deleted), patch
bryner
: review+
asa
: approval-aviary+
Details | Diff | Splinter Review
Firefox's Single Window mode implemented in bug 172962 misbehaves a bit when asked to open an invalid URL. If new windows are preffed to open into tabs, Firefox will open that tab, and then a new window as well. See the attached testcase for details.
Attached file testcase (deleted) —
Blocks: 263570
Nominating to make sure it doesn't slide under the radar, but I expect it to be minused. :-)
Flags: blocking-aviary1.0?
dan, are you close to a patch?
Attachment #162857 - Flags: review?(bryner)
Comment on attachment 162857 [details] [diff] [review] split new-tab and load-URI to allow proper return on URI load error Will this mess up the referrer for the page in the new tab or anything like that?
No. No worse than it already was.
Same as previous patch, but sets up the referrer as well. Note characterSet is already being picked up somewhere. I don't know by whom. Magical elves. But it seems to be always correct in my testing.
Attachment #162950 - Flags: review?(bryner)
Comment on attachment 162950 [details] [diff] [review] get proper return on URI load error and initialize referrer >--- dom/public/idl/base/nsIBrowserDOMWindow.idl 30 Sep 2004 14:20:43 -0000 1.1.2.1 >+++ dom/public/idl/base/nsIBrowserDOMWindow.idl 22 Oct 2004 01:01:13 -0000 Change the IID of this interface. r=me with that change.
Attachment #162950 - Flags: review?(bryner) → review+
ok, lets get this one on the branches
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Comment on attachment 162950 [details] [diff] [review] get proper return on URI load error and initialize referrer a=asa for aviary checkin.
Attachment #162950 - Flags: approval-aviary+
Keywords: fixed-aviary1.0
Whiteboard: trunk req: 172962
verified on windows firefox branch build 2004102607. test cases no longer open another window.
Comment on attachment 162857 [details] [diff] [review] split new-tab and load-URI to allow proper return on URI load error removing obsolete review request
Attachment #162857 - Flags: review?(bryner)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: trunk req: 172962
Target Milestone: --- → Firefox1.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: