Closed Bug 264002 Opened 20 years ago Closed 20 years ago

wpad: DNS lookup before PAC call unnecessary

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: benc, Assigned: darin.moz)

References

Details

from bug 28998, #83, I said: I'm not sure why we add all the DNS stuff like: + rv = dnsService->AsyncResolve(NS_LITERAL_CSTRING("wpad"), PR_TRUE, this, curQ, + getter_AddRefs(request)); We only support doing A rec lookups right? So why don't we just set the PAC URL and load it, it is going to lookup "wpad" when the URL tries to connect. If a PAC load fails, then we use "DIRECT" always anyhow.
> We only support doing A rec lookups right? I'm not sure what you mean by this. We ask the OS to resolve "wpad" to an IP address, and it may return a list of IPv6 and/or IPv4 addresses. How it manages to return that list is well beyond our purview. > So why don't we just set the PAC URL and load it, it is going to lookup "wpad" > when the URL tries to connect. Yeah, good point. I don't understand why we are doing a DNS query here either. Shaver?
Vestigial and harmless, I thought, from when I was trying to find a safe way to do the domain-walk. I would not object to its removal at all.
Depends on: 282442
fixed-on-trunk with patch for bug 282442
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
V/fixed, inspected patch. Thanks.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.