Closed
Bug 264064
Opened 20 years ago
Closed 19 years ago
Lose secure site indicators when customizing toolbars
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox1.5
People
(Reporter: richwklein, Assigned: richwklein)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mconnor
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10.1
If the toolbar is customized while on a secure website, the lock icon, location
bar coloring, and host name are lost from the display.
Reproducible: Always
Steps to Reproduce:
1. go to any secure website.
2. right click on toolbar and select customize.
3. add any item to toolbar, or remove any item from toolbars.
4. click done.
Actual Results:
All secure site information is removed from view.
Expected Results:
Secure information should remain on the display.
Assignee | ||
Comment 1•20 years ago
|
||
Requesting blocking aviary 1.0
Summary: Lose secure site indicators when customizing toolbar → Lose secure site indicators when customizing toolbars
Assignee | ||
Comment 2•20 years ago
|
||
Didn't get blocking request put on for some reason.
Flags: blocking-aviary1.0?
Comment 3•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041012
Firefox/0.10
Confirming
->NEW
in furter detail
1.Customise
2.all location bar text content disappears, color remains yellow
3.drag something off a toolbar
4,press done
5.locationbar only contains url name+favicon, sec icon and yellow are gone
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•20 years ago
|
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Assignee | ||
Comment 4•20 years ago
|
||
This fixes the lose of the security indicators when customizing toolbar on a
secure site. The reason the indicators are lost is because the init function
of the statushandler is called when the toolbar changes. My fix changes the
init function to try and get the security information off the securityui if
available.
Assignee | ||
Comment 5•20 years ago
|
||
Comment on attachment 162728 [details] [diff] [review]
Fix v 1.0
Requesting review
Attachment #162728 -
Flags: review?(firefox)
Comment 6•20 years ago
|
||
*** Bug 274233 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Updated•19 years ago
|
Attachment #162728 -
Flags: review?(firefox) → review?(mconnor)
Comment 8•19 years ago
|
||
Comment on attachment 162728 [details] [diff] [review]
Fix v 1.0
the if/else statement is unnecessary here, securityUI should already be inited
in the browser constructor, and is expected to not fail. We assume so already
elsewhere. See bug 180962
I'll r+ a patch that just has the required two lines changed.
Attachment #162728 -
Flags: review?(mconnor) → review-
Assignee | ||
Comment 9•19 years ago
|
||
Remove if statement
Attachment #162728 -
Attachment is obsolete: true
Attachment #183078 -
Flags: review?(mconnor)
Updated•19 years ago
|
Attachment #183078 -
Flags: review?(mconnor) → review+
Updated•19 years ago
|
Attachment #183078 -
Flags: approval-aviary1.1a1?
Comment 10•19 years ago
|
||
Comment on attachment 183078 [details] [diff] [review]
Version 2.0
a=asa
Attachment #183078 -
Flags: approval-aviary1.1a1? → approval-aviary1.1a1+
Updated•19 years ago
|
Assignee: firefox → richwklein
Comment 11•19 years ago
|
||
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js
new revision: 1.423; previous revision: 1.422
done
Status: NEW → RESOLVED
Closed: 19 years ago
Component: General → Toolbars
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•