User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1 Build Identifier: version 0.8 (20040913) Workaround: 1. Sort by Date 2. View -> Threads -> "Watched Threads with Unread" 3. Sorting is now "Order Received" in View -> Sort By 4. View -> Sort By -> Date Reproducible: Always Steps to Reproduce: 1. Sort by Date 2a. View -> Threads -> "Threads with Unread" 2b. View -> Threads -> "Watched Threads with Unread" 3. Sorting is now "Order Received" in View -> Sort By Actual Results: Sorting is changed. Expected Results: Sorting should not be changed.

xref bug 219787 The preference cited in that bug has no effect on this bug's behavior, tho.

Still a problem with Thunderbird 1.5 (20051201).

I fixed a bunch of whitespace foo here, added a few comments, and also reordered the switch clauses to put "All" at the top of the list. The only substantive change is to preserve the sort order (oldSortType) for the "WithUnread" thread-view types. Works great. The patched code will drop right into Seamonkey's version of this method, altho SM has an extra bit of code at the end of the method, which doesn't need to change -- beginning with the comment: // this is to kick off cross-folder searches for virtual folders. at http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/commandglue.js#432 I don't know why that's there, or why TB doesn't have the same thing.

This is better because the whitespace fixes are included. (Previous version was -uw)

Comment on attachment 254552 [details] [diff] [review] diff -u Looks good to me. >+ CreateDBView(msgWindow.openFolder, nsMsgViewType.eShowAllThreads, viewFlags, >+ oldSortType, oldSortOrder ); Might as well kill that space before the );

Comment on attachment 254552 [details] [diff] [review] diff -u Oh -- I'd intended to ask Neil for R instead of SR. Yeah, that space should come out as well.

Comment on attachment 254552 [details] [diff] [review] diff -u looks good. you might be able to get gavin, magnus or Phil to land this for you.

mozilla/mail/base/content/commandglue.js 1.78