Currently pref-popups does not respect pref locking and does its sound file browsing differently to how it is done for mail notifications and download completion.

This patch: * Implements missing pref locking * Ensures sound.url is a URL * Persists the last sound directory and passes it in to the filepicker * Filters by .wav / .wave

> * Filters by .wav / .wave Why? Last I checked nsISound didn't have this restriction, did it?

From testing (on windows and linux), what is documented in other JS pref stuff and what people have said on IRC, nsISound only seems to understand how to play WAV files. I'd also tried au, mid, ra, ram, rm and mp3. The patch does still give "All files" as option for the filter.

> nsISound only seems to understand how to play WAV files On which platforms?

I've tested on Windows and Linux, I'm hoping to test on Solaris next week.

Okay I've tested on Solaris on it does not understand how to play either .wav or .au files

Changes since v0.1 * Replicated behaviour of Preview button as advised for pref-download * Added accesskeys to checkboxes * Changed "Select..." to "Browse..." and title of filepicker window * Changed fixup to be same as advised for pref-download * Made use of hPrefWindow functions for whitelist populating

The point is, if the nsISound api doesn't say it's limited to wav files, why are we limiting it? On Mac, for example, it looks like it can play any format the OS understands (including video clips, looks like).

Comment on attachment 171516 [details] [diff] [review] Revised lockpref and tidy up changes v0.1a We need to be able to support system sounds because navigator.js does. In fact, this patch doesn't even allow you to restore the default beep. (In reply to comment #8) As per comment #3 we're not actually removing functionality, we're just making it easier for the majority of platforms.

Ian, Neil, Are you still working on this ?

This will probably be closed off when pref panel gets moved across to new prefs window.