Closed Bug 267823 Opened 20 years ago Closed 20 years ago

[BEOS] nsWindow.cpp contains ONWORKSPACE instead of nsWindow::ONWORKSPACE

Categories

(Core Graveyard :: GFX: BeOS, defect)

x86
BeOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Niels.Reedijk, Assigned: Niels.Reedijk)

References

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7.3) Gecko/20041028 Firefox/1.0RC1 Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7.3) Gecko/20041028 Firefox/1.0RC1 From bug 242315 : Also, bit off-topic -looking at your patch i noticed my own old mistake in CallMethod() code. There is ONWORKSPACE: case in switch, but it is wrong - must be something like nsWindow::ONWORKSPACE there. Can you file new bug on that? I will quickly review it, and if tree is open, will try for check patch in before i leave my home (will be in Sweden from 7-th to 21-th October). So new IME patch will be maid against new code with that stupid bug fixed. Reproducible: Always Steps to Reproduce:
Attached patch Quick one-liner (deleted) — Splinter Review
This should be applied to AVIARY and MAIN. Quick one-liner.
Blocks: 266252
Attachment #164654 - Flags: review?(sergei_d)
Summary: [BEOS] nsWindow.cpp contains ONWORKSPACE instead of nsWindow::ONWORKSPACE → [BEOS] nsWindow.cpp contains ONWORKSPACE instead of nsWindow::ONWORKSPACE
Attachment #164654 - Flags: review?(sergei_d) → review+
Comment on attachment 164654 [details] [diff] [review] Quick one-liner Requesting aproval. This is a change in the BeOS code only. It will not affect the other platforms in any way. The patch is reviewed.
Attachment #164654 - Flags: approval-aviary?
Comment on attachment 164654 [details] [diff] [review] Quick one-liner Requesting aproval. This is a change in the BeOS code only. It will not affect the other platforms in any way. The patch is reviewed.
Comment on attachment 164654 [details] [diff] [review] Quick one-liner a=asa
Attachment #164654 - Flags: approval-aviary? → approval-aviary+
Sergei, will you check this one in in the MAIN and AVIARY branches?
Checked in on the trunk: /cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v <-- nsWindow.cpp new revision: 1.86; previous revision: 1.85 and the aviary branch: /cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v <-- nsWindow.cpp new revision: 1.77.6.2; previous revision: 1.77.6.1
Assignee: beos → Niels.Reedijk
Checked in. Fyysik is probably already packing up for his trip tomorrow. Landing this bug affects the Japanese input patch.
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: