Closed Bug 268245 Opened 20 years ago Closed 20 years ago

Junk mail not always moved to Junk folder, left in Inbox instead

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ali, Assigned: Bienvenu)

References

Details

(Keywords: regression)

Attachments

(3 files)

potential fix
(deleted), patch
mscott
: superreview+
Details | Diff | Splinter Review
add logging to diagnose this.
(deleted), patch
mscott
: superreview+
Details | Diff | Splinter Review
possible fix
(deleted), patch
mscott
: superreview+
Details | Diff | Splinter Review 
After upgrading to 0.9 from 0.8 (WinXP), I've found that often Thunderbird will
mark messages as Junk, but will not move them to the Junk mail folder, but will
leave them in my Inbox. The messages have the little trash icon in the email
list pane, but are left in Inbox.

It seems to happen on a per-session basis. After leaving Thunderbird open for
some time (I leave it open hours at a time), something (I have no idea what)
will trigger it, and then until I restart Thunderbird mail will continue to get
marked as junk, but will not get moved to the junk folder.

I don't know how to be more specific in describing this, but if there is any
specific info you need, let me know and I will try to provide it.
Setting severity to major and requesting blocking-aviary1.0 since this makes the
junk mail filter useless until Thunderbird is restarted.
Severity: normal → major
Flags: blocking-aviary1.0?
I am seeing this also in Seamonkey 1.8a5 nightly 2004110406 on Mac 10.3.6.
*** Bug 254348 has been marked as a duplicate of this bug. ***
imap or pop3?
pop3 for me.

(In reply to comment #5)
> pop3 for me.
> 

it's exactly the same for me. thunderbird 0.9 on winXP, update from a 0.8. and POP3
POP3 over SSL for me.
version 0.9 (20041103), Windows XP

I had the same problem. I have multiple accounts, now it just happened for a
POP3 account. (Can't remember or couldn't check for other accounts (SSL POP3 and
SSL IMAP) since there was no junk there at the moment).
After restarting Thunderbird and manually running junk mail filters on the
folder, the junk mails were moved.
Same thing happens to me.  When I first open thunderbird and pull mail junk get
flagged and moved to junk folder.  Subsequent pulls of mail makrs the mail as
Junk, but doen't move the mail.  manually marking as junk does continue to move
to junk folder.
when you say "subsequent pulls", do you mean you click get new mail? Does this
happen right away, i.e., the first time you do get new mail after the intial
startup get new mail? Are you using the global inbox or a per-account global
inbox? Is the inbox selected when you do a get new mail?
Assignee: mscott → bienvenu
Flags: blocking-aviary1.0? → blocking-aviary1.0+
So far this has never occured for me during the first check of mail after
Thunderbird opens (though I wouldn't read too much into this, since there
appears to be no real pattern to when it starts to happen). It's always happened
for me on a subsequent pull, but once it happens, automatic pull at time
interval or manual by Get Mail have the same effect as in comment 0. So it's not
just when I "Get Mail", but also when Thunderbird pulls mail on its own.

I am using per account Inbox. To my recollection, the Inbox has usually
(always?) been selected when this happens. It probably has always been selected,
since I have a habit of always re-selecting my Inbox once I'm done reading mail
in other folders.
when you say trash icon, you mean junk icon, right? And you all are using the
default Junk folder as the folder to move to? If you turn on the junk mail
logging, what does it say once you get in this state?
Yeah, I mean the junk icon. Next time this happens, I'll try and compare the
junk mail log and see if anything is amiss there (i.e. different from when its
normally working).
Attached patch potential fix (deleted) — — Splinter Review 
make sure we decrement mNumFilterClassifyRequests at the beginning of the
method, in case we error out before we get to the part where we check if it's
0. The theory being, if it miss decrementing it, the count will never get to 0.
Comment on attachment 165661 [details] [diff] [review]
potential fix

the other possibility is that we're trying to do the copy, but it's failing...
Attachment #165661 - Flags: superreview?(mscott)
Attachment #165661 - Flags: superreview?(mscott) → superreview+
Attached patch add logging to diagnose this. (deleted) — — Splinter Review 
this adds logging with an rv if the move call fails.
Attachment #165741 - Flags: superreview?(mscott)
Attachment #165741 - Flags: superreview?(mscott) → superreview+
Confirmed bug introduced in .9 Thunderbird; .8 was fine.
This happens for me now on both XP SP1 and Mac OS X 10.3.6 - enabled junk
logging, log reports for one message:

Detected junk message from "Jonathan Boucher" <boucher_bn@helimail.de> -
Application is pre approved at 2004-11-12 22:49:22 Move message id =
f99c01c4c94c$255a2ff0$55041e42@neurotec.ki.se to
mailbox://nobody@Local%20Folders/Junk 

I have 5 identical pop accounts on both platforms.  The problem is happening so
far only with my speakeasy pop, domain greglynn.com.
Greg (or anyone else), can you try today's build (which has the first patch
checked in), or tomorrow's build (which has extra logging), and let me know if
it still happens?
also, Greg, was that log for a message that was marked as spam but *not* moved?
Are all accounts moving mail to the same junk folder?
(In reply to comment #19)
My log says:
"Detected junk message from jessie@bananabread.net - Let's talk, my friend! at
2004-11-13 09:58:38 Move message id = ixxdsssydrjizakgjvk@bananabread.net to
mailbox://andrew%40bananabread.net@bananabread.net/Junk"
It shows the moves to junk as above even though the junk was not actually moved.
They are marked as junk but then left in the original in box.
I see something similar to comment 20, my log for that particular entry is as
follows (where it was not moved to Junk):

Detected junk message from "Mercenaries Q. Twitting" <jpglmr@execpc.com> -
=?iso-8859-1?B?R2V0IGFueSBtZWRpY2F0aW9uLCBjb21wbGV0ZWx5IEFOT05ZTU9VUy4g?= at
2004-11-15 14:39:42 Move message id = 111001c4cadd$e07a0612$6b2a7aa9@execpc.com
to mailbox://aebrahim@pop.XXXXspamXXXX.edu/Junk

Interestingly, the subject in the message source was:
=?iso-8859-1?B?R2V0IGFueSBtZWRpY2F0aW9uLCBjb21wbGV0ZWx5IEFOT05ZTU9VUy4g?=

I wonder if this has to do with messages with badly formed subject lines? This
is the first time this has happened again since I reported the bug. I shall have
to check next time and see if the next time the subject line is also weirdly formed.
Oh well, it happened again, and my theory from comment 21 was shot down. The
messages had perfectly normal subject headers this time.
Has anyone tried a build with the additional logging and potential fix?

btw, some people say that once this happens, it keeps happening until they
restart. Are other people seeing it intermittently happening during the same
session?
I'm seeing this now in my release build, but I've not seen it in my debug build
In Linux, I see this after upgrading from Thunderbird 0.8 to 0.9 using debian
preview release 0.9-4 from the maintainer:
http://www.jwsdot.com/debian/install.html

About 2% of the spam messages are correctly flagged, but not automatically moved
from the Inbox to the Junk Folder.

This is a POP3 account.

David, how can we get protocol log for Junk detection and Junk move?
I do not know filtering related parameters except "MsgPurge:5".
you turn on junk mail logging through the junk mail controls
(In reply to comment #27)
> you turn on junk mail logging through the junk mail controls
I change my question.
David, are there any effective tracing mechanism for problem of "Junk mail is
not moved to Junk folder even when a mail is detected as Junk"?

I added more logging to the junk mail logging that might help.
To all who is experiencing this bug's problem :
(Q1)Do you use message filter rule of "Set Junk Status to Junk"?
    If this rule is used, mail marked as Junk is not moved to Junk folder,
    unless "Move to  folder" is used in conjuction with rule of marking as Junk.
    I do not know whether bug or spec, but this is being discussed by Bug 248758.

Additonal test result.
In my test, test mail(subject=spam, mail body=spam, which was marked as Junk but
wasn't moved to Junk) was moved to Junk folder when "Run Junk Mail Control on
Folder" on Inbox.

(In reply to comment #29)
> I added more logging to the junk mail logging that might help.
Sorry. I missed your comment #16.
Thanks for enhancement.
No, I don't have any filters that set Junk status.
To all who is experiencing this bug's problem :
(Q2) Are all accounts moving mail to the same junk folder?
    (question by David in comment #19)
(Q1)Do you use message filter rule of "Set Junk Status to Junk"?

No

(Q2) Are all accounts moving mail to the same junk folder?

Yes
I was playing around with thunderbird to find the reason for this bug. I created
a new account and checked why it worked and my old account did not work. I found
that there is a big mess with servers and identities. For months now, this
system of accounts, ids and servers is buggy because it was never clearly
designed. And for months, people are hacking around in the code to fix all the
bugs, but they don't know what they are really doing. And nobody tries to clean
that mess. Is's like cleaning your house by moving the trash from one room to
another.

For example, there are the settings "mail.server.server1.userName" and
"mail.server.server1.hostname". 
These differ from "mail.server.server1.realhostname" and
"mail.server.server1.realuserName". 
Generally, "userName" and "hostname" are wrong.

Then there is the setting "mail.server.server1.spamActionTargetAccount". 
It uses "mail.server.server1.userName" and "mail.server.server1.hostName". This
is wrong because "hostName" and "userName" are meaningless. It should use
"realhostname" and "realusername".

And - to my big surprise - the setting
"mail.server.server1.spamActionTargetFolder" points to a completely wrong
mailbox. Only the last part of the directory is ok. But the username and
mailboxname is wrong.

Big big mess. Maybe it can be fixed in a quick-over-night-patch by introducing a
veryRealHostname and veryRealUsername?

(Btw: I found that some directories are attached to the id and some to the
account. What happens if 2 ids are linked to the same account??)

the userName and realUserName prefs have been around for a long time, for a very
specific reason - to allow you to edit the username and host name of a server,
w/o invalidating existing uri's. The uri's,use the original userName, not the
realUserName pref. The realUserName is used when talking to the server...

Maybe you could attach or e-mail me your prefs.js with a more specific
description of which prefs are wrong...
What I forgot: why does the setting "mail.server.server1.name" contain the
account name? Shouldn't this be in "mail.server.account1.name"?

Would it be useful do create a ER-model of account, server and id?

(In reply to comment #30)
> To all who is experiencing this bug's problem :
> (Q1)Do you use message filter rule of "Set Junk Status to Junk"?

Yes.

>     If this rule is used, mail marked as Junk is not moved to Junk folder,
>     unless "Move to  folder" is used in conjuction with rule of marking as Junk.

Yes, of course. 

(In reply to comment #32)
> (Q2) Are all accounts moving mail to the same junk folder?

No.  One account moves junk to another's junk folder.  But the bug appears in
the default account with no other accounts moving junk to this account folder.


At the end, the fix was easy: I deleted PANACEA.DAT and all works fine now!

This bug should be Product=Core, Component=MailNews: Filters.
And same problem as bug 196732, I think.
I think that this bug depends on (or is related to) 271472 which I have just
submitted.

Both bugs are frequently reproducable on my system.
RE comment 39, the reason I filed this under Thunderbird was because I had never
seen it in 0.8 (and previous), and I only saw this in 0.9. Since all these
releases came off the aviary 1.0 branch, I didn't see how it could be related to
bugs in MailNews filed years ago.

I could be wrong, feel free to correct.
Attached patch possible fix (deleted) — — Splinter Review 
if for some reason, we classify a message, but don't get OnMessageClassified
called, the count will never go to 0. This attempts to work around this by
resetting the counter whenever ClassifyMessages is called. It's worth a try...
Attachment #167051 - Flags: superreview?(mscott)
Attachment #167051 - Flags: superreview?(mscott) → superreview+
last patch checked in - I don't know if it will fix the problem, but please
re-open this bug if you see it with builds from after today.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
I still see this bug in version 0.9+ (20041128).

Spam arrives, is marked Junk, but stays in the inbox.

I don't know how to Reopen this bug though, so its status is staying at RESOLVED.
Doesn't seem like proper procedure to RESOLVE a bug without any testing,
let alone thorough testing.

(I haven't testing with a newer version.)
I've never been able to reproduce the problem, so there's not much else I can
do...you can always re-open the bug if the problem persists with the latest builds.
(In reply to comment #45)
> Doesn't seem like proper procedure to RESOLVE a bug without any testing,

Resolution=FIXED means "fix is available and fix is checked in".
Status of "FIXED" bug is tracked by "Status".
When fix is available, Status=RESOLVED is set.
On successufull fix verification, Status=VERIFIED is set.
This is "definition".
Read description about Bugzilla system of mozilla.org.
If you can not agree on current *definition* of Status/Resolution,
open bug of Bugzilla system of mozilla.org, please.
(In reply to comment #44)
> I still see this bug in version 0.9+ (20041128).
> Spam arrives, is marked Junk, but stays in the inbox.
Bug 272356 for similar problem has been closed as "WORKSFORME" with current nightly.
What is the difference of your case from reporter's case or commenter's case in
other similar bugs?
When or How problem occurs, on What environment/settings problem occurs, and so
on are very important.
Navid, add such important information in addition to saying "Junk is still not
moved for me!", please.
On version 1.0 (20041206) the bug is reproduced.
Junk letter was marked as Junk but not moved into Junk folder.

More information:
OS: Windows XP + SP2
Individual Junk folder and rules exist for each mail boxes.
Local folders not used for receiving letters.

Please feel free for more questions about the bug reproducing.
I'm also seeing this problem in Thunderbird 1.0 (win 2k). In my case, I have
multiple POP3 and IMAP accounts all pointing to the same Junk folder. The IMAP
folder is the one that gets most incoming mail and where I see Junk icon on mail
"left in the inbox".

Settings: Move incoming messaged determined to be junk mail to OTHER 
  Automatically delete junk older than...
  When I manually mark: move to Junk folder

Sometimes the automatic works and sometimes not. Manual always works.
I still have this bug in thunderbird 1.0

Still having this problem with 1.0.2-1.3.2 (20050324) on Fedora Core 3.  I was
hoping it would go away when I upgraded from 0.9.  Everything works fine for a
while, then randomly junk-marked messages stop being moved.  Restarting solves
the problem, until it recurs.
This Problem is still an issue on Thunderbird version 1.5 Beta 2 (20051006)
Please reopen
Confirmed in Thunderbird 1.5rc2. I can't find a reliable way to reproduce it, but it seems more likely to happen when downloading messages on startup. I am sorting incoming mail to subfolders of the global inbox, although I had the same problem with 1.0.2 and mail going straight into the Inbox.

This bug should be reopened.
(In reply to comment #54)
> This bug should be reopened.

See bug 196732.
Also see this bug on Thunderbird version 1.5 (RC2 du 20051201), Windows XP/SP2
I have several IMAP accounts, and all junk mails automatically moved to a Junk folder on my "Local Folders".
I have noticed an additional problem when junks are no more automatically moved. 
If I try to move then with a drag and drop, nothing happen. I can no more move an
email from my IMAP account to the "Local Folders" using drap and drop.
With 1.501, all my IMAP junk mail stays in the inbox. It is never moved to any folder nor deleted.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: