Closed
Bug 270128
Opened 20 years ago
Closed 16 years ago
keyboard cannot be used for text entry if address bar history entry is selected with mouse while pulldown menu is active from hotkey
Categories
(SeaMonkey :: Autocomplete, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: forum, Assigned: neil)
References
Details
(Keywords: assertion)
Attachments
(1 file)
(deleted),
patch
|
aaronlev
:
review+
ajschult784
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Refer to steps/results
Reproducible: Always
Steps to Reproduce:
1. Hit alt-d to jump to address bar (or whatever method you want to put focus on
address bar).
2. Type anything in address bar to cause address bar history (if any) and
"search google" to appear. Do not press enter.
3. Hit alt-g or any other alt-hotkey (FEVGBTWH) to open a pulldown menu.
4. Use mouse to select (left click) something from opened address bar history
(either a url, or "search google" option)
Actual Results:
No navigation results, and the keyboard now cannot be used to enter text. This
includes both in selecting/typing in the address bar, and typing text in any
forms that the browser window may coincidentally be displaying. Hotkeys (alt-
and ctrl- selections) can still be used, except for alt-d.
Switching the focus off the browser window and then back to the browser window
will clear this problem.
Expected Results:
The usual magic. ;-)
Comment 1•20 years ago
|
||
Confirming.
This raises this assertion on a debug build :
http://lxr.mozilla.org/seamonkey/source/dom/src/base/nsFocusController.cpp#477
"Attempt to decrement focus controller's suppression when no suppression active!"
We should check if FireFox has the same problem.
Assignee: general → bryner
Status: UNCONFIRMED → NEW
Component: Browser-General → Event Handling
Ever confirmed: true
Comment 2•20 years ago
|
||
Confirming on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5)
Gecko/20041110 Firefox/1.0
Comment 3•20 years ago
|
||
Is this a problem on trunk? This worksforme with a current Linux trunk build.
Comment 4•20 years ago
|
||
Still broken on Windows/Trunk/Suite W2000.
Maybe it doesn't impact Linux for some reason.
Comment 5•20 years ago
|
||
In that case, it's likely to be a widget issue, not an event handling one....
Assignee: bryner → win32
Component: Event Handling → GFX: Win32
QA Contact: general → ian
Comment 6•20 years ago
|
||
This is indeed windows only.
There seem to be subtles difference between Linux and Windows, I could get in
some circumstances the history bar and a drop down menu to be simultanesously
opened under Linux when selecting with the mouse, but never under Windows.
Maybe the best solution would be that access to a menu with a keyboard shortcut
would close the history bar, as it does when selecting with the mouse.
I suspect that in the mouse selection case, this behaviour has been deliberately
implemented to avoid problems with the two simultaneous drop-down.
Comment 7•20 years ago
|
||
Hmmm... yes, that would be a good idea.
Assignee | ||
Comment 8•20 years ago
|
||
Assignee: win32 → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #167643 -
Flags: superreview?(jag)
Attachment #167643 -
Flags: review?(aaronleventhal)
Assignee | ||
Updated•20 years ago
|
Component: GFX: Win32 → XP Apps: Autocomplete
Product: Core → Mozilla Application Suite
Comment 9•20 years ago
|
||
Comment on attachment 167643 [details] [diff] [review]
Close popup when ALT pressed
[Checkin: Comment 13]
Good job remembering to handle the Mac case where there is no menu access key.
Attachment #167643 -
Flags: review?(aaronleventhal) → review+
Comment 10•20 years ago
|
||
jag's not available to sr this ?
Comment 11•17 years ago
|
||
Neil, Jag,
Are you still working on this ?
Assignee | ||
Updated•17 years ago
|
Attachment #167643 -
Flags: review?(ajschult)
Comment 12•16 years ago
|
||
Comment on attachment 167643 [details] [diff] [review]
Close popup when ALT pressed
[Checkin: Comment 13]
what's described in comment 0 doesn't happen on linux, but this does prevent focus from being so greedy when the autocomplete menu is down (which is very annoying)
Attachment #167643 -
Flags: review?(ajschult) → review+
Assignee | ||
Comment 13•16 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 14•16 years ago
|
||
Comment on attachment 167643 [details] [diff] [review]
Close popup when ALT pressed
[Checkin: Comment 13]
(Are you still looking for sr ?)
Attachment #167643 -
Attachment description: Close popup when ALT pressed → Close popup when ALT pressed
[Checkin: Comment 13]
Comment 15•16 years ago
|
||
Comment on attachment 167643 [details] [diff] [review]
Close popup when ALT pressed
[Checkin: Comment 13]
Clearing sr, patch already checked in.
Attachment #167643 -
Flags: superreview?(jag)
Comment 16•16 years ago
|
||
Patch checked into mozilla-central in Bug 443837
Comment 17•7 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/df6e968a4f9c
Menu access key should close autocomplete r=aaronlev,ajschult [p=Neil]
You need to log in
before you can comment on or make changes to this bug.
Description
•