Closed Bug 270434 Opened 20 years ago Closed 14 years ago

Thunderbird should not ignore middle mouse button click or Ctrl+Click on Links/URLs in messages

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.3a1

People

(Reporter: eyalroz1, Assigned: tbertels+bugzilla)

References

Details

Attachments

(1 file)

I'm used, from MailNews, to opening links with a click using the middle mouse button. But in TB, this does nothing... I suggest that a middle mouse button, if not having some special action to get the same effect as 'open in new browser tab' in MailNews, should at least be the same as a left mouse button click.
Coming from the Mozilla Suite, I do agree the middle-click behavior "open in new browser tab" is very missing. I'd like the same feature to cope with any mozilla browser (Firefox, Mozilla Navigator...). Actually, the lack of the feature prevents me to switch to Firefox + Thunderbird. Really.
This is not just Thunderbird. The same behavior has appeared in the Mandrake Mozilla 1.7.5 RPM.
(In reply to comment #2) That is a different bug altogether. Thunderbird is not _supposed_ to have this behavior now, I'm asking for it as a feature. Mozilla suite _is_ supposed to have it, so if it's not working, that's either a problem with Mandrake, with the RPM or with Mozilla 1.7.5.
This is what I'd like to see it do: Left mouse click a link: Open a new window/tab in the user's default browser *in the foreground* - the browser appears in front and takes the focus (how it works now). Middle mouse click a link: Open a new window/tab in the user's default browser *in the background* - Thunderbird keeps the focus and stays in front (if you see what I mean). What do people think?
I disagree. I believe the behavior should be just as though you were middle-clicking in MailNews and having the link opened in a seamonkey browser window. That is to say, the browser's new tab policy should dictate whether the new tab should be opened in the background or not. Uniformity of interface behavior of both seamonkey and ff+tb is what's missing AFAIAC.
(In reply to comment #3) > Mozilla suite _is_ supposed to > have it, so if it's not working, that's either a problem with Mandrake, with the > RPM or with Mozilla 1.7.5. > This feature doesn't work with Mozilla 1.7.5 Debian package, too.
Try opening a different bug (if one does not already exist) regarding the middle-click issue with Mozilla suite on Linux. Resummarizing.
Summary: middle mouse button click should not be ignored → Thunderbird should not ignore middle mouse button click
Blocks: 282239
Let this be about doing /something/ on middle-click (e.g. same as left-click, as suggested in comment 0) and bug 273058 is about making it configurable.
Blocks: 273058
Version: unspecified → Trunk
The left mouse-button does what it should. The middle-button should open a new tab in the background (keeping focus on Thunderbird). It is very anyoing, when you read newsletters to always switch between TB and FF. Costs a lot of clicks refocussing on the newsletter each time you click on a news headline. If someone does not like this feature, s/he can use the left button! BTW this feature is working in Moz Suite, why not use it?
(In reply to comment #10) > See also: > Bug 172962 Comment #107 > > Bug 35578 > Bug 255123 > Bug 263553 These bugs do not handle the problem of keeping the focus on Thunderbird. Is anybody working on this problem?
Flags: blocking-aviary2.0?
(In reply to comment #5) > I disagree. I believe the behavior should be just as though you were > middle-clicking in MailNews and having the link opened in a seamonkey browser > window. That is to say, the browser's new tab policy should dictate whether the > new tab should be opened in the background or not. Uniformity of interface > behavior of both seamonkey and ff+tb is what's missing AFAIAC. I disagree that this is a trivial bug it affects me on a daily basis and it is a consistency issue that needs to be resolved. However I'm afraid I do not have the knowledge to do so.
Flags: blocking-firefox2? → blocking-thunderbird2?
Flags: blocking-thunderbird2? → blocking-thunderbird2-
QA Contact: front-end
Flags: blocking-thunderbird3?
No longer blocks: 273058
Assignee: mscott → nobody
Severity: trivial → enhancement
Flags: blocking-thunderbird3? → wanted-thunderbird3.0a1?
Moving from wanted‑thunderbird3.0a1? flag to wanted‑thunderbird3.0a2? flag since code for Thunderbird 3 Alpha 1 has been frozen.
Flags: wanted-thunderbird3.0a1? → wanted-thunderbird3.0a2?
Flags: wanted-thunderbird3.0a2? → wanted-thunderbird3?
Blocks: 435567
I haven't given this problem too much thought so I'm not too sure about this, however I am planning on making the middle click mouse button open folders, accounts, and messages in new tabs (bug 435567). ref: bug 218999 and the landing of the patch in bug 402365 Is there a way to open up new links in a tab in other browsers like IE, Safari?
Yes - IE7, Safari, Opera, Chrome all open new tabs by middle-click.
> Yes - IE7, Safari, Opera, Chrome all open new tabs by middle-click. By middle clicking from a different application? I assumed that's what this bug was about.
Ah, correct. That part I assume is semi-nonfixable... Plus, now it would be odd if thunderbird didn't use the middle-click to open it's *own* tags.
Not an immediate focus of TB 3. Doesn't mean we wouldn't accept patches though.
Flags: wanted-thunderbird3? → wanted-thunderbird3-
Isn't this bug fixed because of the fix for Bug 435567?
I don't think so, that's just about opening mail messages, not web links, right?
My bad. I did not make out the difference on the first go around. Sorry.
Summary: Thunderbird should not ignore middle mouse button click → Thunderbird should not ignore middle mouse button click or ctrl click
Why the "middle" mouse button at all? Isn't this what is expected of the left mouse button anyhow? Not sure if the "Tab Clicking Options" extension at http://twanno.mozdev.org/ would help here or not.
(In reply to comment #21) > Not an immediate focus of TB 3. Doesn't mean we wouldn't accept patches though. Which file(s) do I have to look at for a patch? (MXR-links)
Summary: Thunderbird should not ignore middle mouse button click or ctrl click → Thunderbird should not ignore middle mouse button click or Ctrl+Click on Links/URLs in messages
AFIAK there is no existing mozilla code to do this - so you'd be writing it from scratch - likely one implementation per platform.
(To make it middle click open like a normal click shouldn't be too hard of course, it's the "extra" features like making it open in background/tab-in-browser that are hard.)
(In reply to comment #29) > http://mxr.mozilla.org/comm-central/source/mail/base/content/contentAreaClick.js#117 Thank you, Dan. Questions: 1) Where are the modifiers checked? I don't see any modifier differentiation (ctrl/alt/shift) in the code. But we do differentiate, otherwise ctrl+leftclick would do the same as leftclick. Any hints as to where that happens? 2) contentAreaClick.js - where is it in the build? Could you help me locate that file in my existing TB3pre installation? Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091013 Shredder/3.0pre This is where I looked but did not find the file: C:\Programme\Shredder3.0pre\chrome\messenger.zip, and therein: content/messenger/ That's where I find some of the neighbouring files (configEditorOverlay.xul, credits.xhtml), but not contentAreaClick.js. So where is it?
(In reply to comment #30) > (To make it middle click open like a normal click shouldn't be too hard of > course, it's the "extra" features like making it open in > background/tab-in-browser that are hard.) I think this bug actually wants ctrl+left-click on links to do the same as just left-click on links. Which imo would be nice behaviour: STR: 1) read mail 2) left-click on link in msg body 3) ctrl+left-click on link in msg body Actual behaviour: 2) left-click opens the link in the default browser (FF) (in a new tab, which is probably just the default for URLs passed to FF from externally) - ok 3) ctrl+left-click: nothing happens - this bug Expected behaviour: 3) ctrl+left-click (just like left-click) should open the link in the default browser (FF) (in a new tab) IMO, no need to add extra complexity here, we just want ctrl-click to open the link rather than do nothing. Magnus, any problems with the expected behaviour?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100608 Lightning/1.0b2 Thunderbird/3.1 Part of this bug seems fixed: Ctrl-Clicking on auto-linkified and real links in a mail messages now opens the page in the default browser in a new tab, as requested by this bug. Middle-Clicking unfortunately still doesn't do anything at all.
No longer blocks: 435567
Follow-up of bug 527922: only check for right click.
Assignee: nobody → tbertels+bugzilla
Attachment #453026 - Flags: review?(philringnalda)
Comment on attachment 453026 [details] [diff] [review] Handle middle mouse button click on links Changing the review to a ui-review - the UI change needs confirmation especially as Bryan wasn't convinced about this bug before.
Attachment #453026 - Flags: review?(philringnalda) → ui-review?(clarkbw)
Comment on attachment 453026 [details] [diff] [review] Handle middle mouse button click on links I can't think of a real issue with this change and our cmd/ctrl click works in a similar way so lets see how it goes.
Attachment #453026 - Flags: ui-review?(clarkbw) → ui-review+
Attachment #453026 - Flags: review?(bugzilla)
Comment on attachment 453026 [details] [diff] [review] Handle middle mouse button click on links This looks fine, thanks for the patch. r=Standard8.
Attachment #453026 - Flags: review?(bugzilla) → review+
Thanks, I've checked this in for you as well: http://hg.mozilla.org/comm-central/rev/13f020c62b7a
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
You're welcome. And thanks for the reviews.
As a retail product end user without access to the development tools for TBird, how would I add middle-click support to Thunderbird, like version 3.1.20, I haven't and wont be updating to latest TBird versions? The app installed folders have numerous js files that I could update with equivalent code, but not the contentAreaClick.js referenced and updated with the few lines of code necessary to support middle-clicks on URLs to open in default web-browser / firefox. Hope you can help id what files I could add equivalent code to, and what that code would be in context/line numbers of the file to update. Thanks for any help you can offer, aside from install latest TBird version!
I hope you realize tb 3.1 is an ancient version, with numerous known security problems. You really should update.
You can extract all the .jar files and search for the contentAreaClick.js. Then you replace the original contentAreaClick.js in the .jar file by the edited one.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: