If a zip file is corrupted, the apache thread crashes and squid only says "zero data returned". We should explore alternatives such as calling unzip via the shell. This would also keep us from having to custom-compile things.

Not going to happen for update-beta. Dumping overboard.

Bulk Moving Developer Control Panel bugs to new component. (Filter: massdevcpspam)

Why not use the pclzip package? It's PHP only (nothing needs to be recompiled) and LGPL: http://www.phpconcept.net/pclzip/index.en.php

This patch lets you choose defining the USE_UNZIP constant if you want to use zip library or unzip executable. Automatic fallback occurs also if zip library is not compiled in our PHP setup.

Comment on attachment 172285 [details] [diff] [review] Fix for this bug The code looks good to me. I need to test it before I can approve it though.

What are we planning for bugs like this that were originally targeted for UMO2.0? WONTFIX for now?

It's not really necessary, since the server can already properly process things using zzlib. It should be noted in the wiki, though. Anybody disagree? On the other hand, it might be worth it if the existing patch would stil work... but if you guys would rather focus on other items, then we could WONTFIX it.

(In reply to comment #9) > It's not really necessary, since the server can already properly process things > using zzlib. It should be noted in the wiki, though. Anybody disagree? The server can properly process things using zziplib because we custom-compiled our PHP to include it (which is a pain in the butt every time PHP has a security update). Finding a supported (i.e. available in RHEL 4 or the dag repo) way to do this would still be appreciated (and would make security updates available more quickly).

Comment on attachment 172285 [details] [diff] [review] Fix for this bug UMO v2 is live. I had a lot less to do with its development, so check with morgamic before using me for reviews.

Do we still screw up the web server if given a malformed zip? That would be very sad, though unzip may well have similar bugs. morgamic: can you investigate this in the next little while?

AMO bugspam. Correcting QA contacts on OLD bugs (mozilla.update@update.bugs) -> Correct QA contact (developers@add-ons.bugs) Filtermeplzkthx

This is fixed in Remora (AMO v3). We are using PEAR's Archive_Zip, so no custom PHP will be required. I uploaded the attached broken xpi and it told me that install.rdf cannot have an updateURL, so I guess it works!