When someone is uploading a file with an install.rdf, we can tell whether it is a theme or not, at least for FX and TB. Themes have an instance of em:internalName. If someone tries to upload a new item incorrectly, this will catch it and prevent us from having to go back and fix it manually.

The question is not whether we can, the question is, do we really *need* to? and is it practical to? For once, let's wait and see what real authors who use the system actually want/need, before filling buglists with minor bugs like this.

Bulk Moving Developer Control Panel bugs to new component. (Filter: massdevcpspam)

This way we don't have to guess Theme or Extension based on the URL.

Comment on attachment 169129 [details] [diff] [review] Allow user to not have to specify theme or extension Question: if bug 271272 is moving this to RDF parsing and not regexs. why is this patch using a regexp? This probably should be done right, if it's going to be done at all and be built on top of the pending patches in Bug 271272. Aside from that, I'm still unconvinced that this gains us anything besides unexpected trouble if em:internalName is ever fubared by an author. Particularly considering this patch removes the previous code and doesn't allow for author error.

if em:internalName is fubarred, then the theme jar is invalid. I patched against current source, since you hadn't reviewed or checked in the RDF parsing patch.

Comment on attachment 169129 [details] [diff] [review] Allow user to not have to specify theme or extension we use the XML parser now

Mass change - bugs to be read / (re)confirmed.

AMO bugspam. Correcting QA contacts on OLD bugs (mozilla.update@update.bugs) -> Correct QA contact (developers@add-ons.bugs) Filtermeplzkthx

Fixed in Remora (though I wonder about things like the Joga extension, which also had a theme component to them).