Closed Bug 271295 Opened 20 years ago Closed 14 years ago

Freeze nsIDOMWindow2

Categories

(Core Graveyard :: Embedding: APIs, defect)

Product:
Core Graveyard
Component:
Embedding: APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: jhpedemonte, Assigned: adamlock)

References

(
URL
)

Details

nsIDOMWindow2.idl, in dom/public/idl/base/Makefile.in, is listed as SDK_XPIDLSRCS, which is used for frozen interfaces. However, this interface is not actually frozen (no "@status FROZEN").
Blocks: 268520
i'd like access to this property from js. i know there are security concerns, these can be handled by security checks.
timeless: i don't think that is a pre-req to freezing this interface. the change could be made after this interface is frozen. (if you want that change to be made, then perhaps you should file a new bug.)
i'm not sure i could make it after you freze the interface...
timeless: The interface is already effectively frozen because it was included in the Gecko SDK. What do you mean by your comment? Why do you think removing [noscript] cannot be done without changing the ABI for C++ users?
Including this interface in the SDK was clearly an error in light of the comment I mention in comment 1 of this bug. If we _do_ have to freeze it, we probably need an nsIDOMWindow3 to handle the issues mentioned therein.
> Including this interface in the SDK was clearly an error in light of the comment > I mention in comment 1 of this bug. Sure, but what's done is done. Jst agreed that this interface should be frozen. nsIDOMWindow3 is where the rest of those nsIDOMWindowInternal things could live.
it would change the interface for anyone implementing nsIDOMWindow2...
URL: http://lxr.mozilla.org/seamonkey/sour...
timeless: fair enough; i agree that that could be a problem. i doubt there are existing implementors outside our source code, but i could be wrong i guess.
i'd agree with you, but when i make that argument later, someone will give me the argument i gave today. i'm always in a lose lose situation.
QA Contact: apis
We no longer freeze interfaces.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.