Closed
Bug 271567
Opened 20 years ago
Closed 19 years ago
Add back onload XPInstall
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mkaply, Unassigned)
References
Details
(Keywords: fixed1.8, testcase)
Attachments
(2 files)
(deleted),
patch
|
dougt
:
review+
mscott
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
(deleted),
text/html
|
Details |
Now that we have XPInstall whitelisting, it doesn't make any sense to block
onload XPIs anymore.
We should add them back.
Comment 1•20 years ago
|
||
For the trunk onload blocking is the only thing active right now. We need a
whitelisting UI for the Suite before it makes sense to turn on the whitelisting,
and we need to turn on whitelisting before it makes sense to fix this one.
But, we should do all of the above.
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•20 years ago
|
||
Any traction on this?
Also see:
https://bugzilla.mozilla.org/show_bug.cgi?id=263872
Comment 3•20 years ago
|
||
*** Bug 296175 has been marked as a duplicate of this bug. ***
Comment 4•19 years ago
|
||
Updated•19 years ago
|
Attachment #194513 -
Flags: superreview?(jst)
Attachment #194513 -
Flags: review?(dougt)
Updated•19 years ago
|
Attachment #194513 -
Flags: review?(dougt) → review+
Updated•19 years ago
|
Flags: blocking1.8b4?
Updated•19 years ago
|
Flags: blocking1.8b4? → blocking1.8b4+
Comment 5•19 years ago
|
||
Comment on attachment 194513 [details] [diff] [review]
Don't block onload installs
We're removing code that we had intentionally added back before Firefox had per
site white listing.
Attachment #194513 -
Flags: superreview?(jst) → superreview+
Updated•19 years ago
|
Attachment #194513 -
Flags: approval1.8b4?
Comment 6•19 years ago
|
||
Fix checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 7•19 years ago
|
||
after this is verified on the trunk, we'll consider for branch approval.
Is XPInstall whitelisting enabled in SeaMonkey? It seems that the
'xpinstall.whitelist.required' default is 'false' in SeaMonkey/20050901.
Comment 9•19 years ago
|
||
testcase: install Spider from bclary.com in onload. In Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050902 Firefox/1.6a1 this shows the
yellow info bar if the site is not whitelisted, and shows the install dialog if
the site is whitelisted.
Comment 10•19 years ago
|
||
verified with bc testcase on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.9a1) Gecko/20050902 Firefox/1.6a1
Status: RESOLVED → VERIFIED
Comment 11•19 years ago
|
||
Comment on attachment 194513 [details] [diff] [review]
Don't block onload installs
Let's get this landed on the branch ASAP. Thanks!
Attachment #194513 -
Flags: approval1.8b4? → approval1.8b4+
Comment 12•19 years ago
|
||
(In reply to comment #8)
> Is XPInstall whitelisting enabled in SeaMonkey? It seems that the
> 'xpinstall.whitelist.required' default is 'false' in SeaMonkey/20050901.
SeaMonkey has not turned on whitelisting primarily because without the infobars
there's no simple way to add a site to the whitelist. Given the problems in bug
295058 we can't put this off any longer on SeaMonkey's account hoping for the
day someone steps up and implements infobars. (bug 295058 afflicts SeaMonkey as
well).
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•