Closed
Bug 272117
Opened 20 years ago
Closed 20 years ago
Menu doesn't update "Open in Tabs" when adding or deleting items in manager
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikepinkerton, Assigned: mikepinkerton)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Usul
:
review+
me
:
review+
|
Details | Diff | Splinter Review |
Create a new folder in bookmark manager in the bookmark menu
put an item in it
expected:
should have "open in tabs" in the menu
actual:
it doesn't until a restart
basically i wasn't correctly watching for add/remove notifications from the bm
manager code. Fix upcoming that should go on the branch.
|
Assignee | |
Comment 1•20 years ago
|
||
this fixes it and moves a bit of code around to reuse it. it's simpler than the
patch implies.
josh? geoff? can you give this a gander asap since it needs to go on the branch
too?
|
||
Comment 2•20 years ago
|
||
Comment on attachment 167258 [details] [diff] [review]
fix
Works fine.
Attachment #167258 -
Flags: review+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 167258 [details] [diff] [review]
fix
this works fine and looks ok. r=me@mollyandgeoff.com
|
|
Assignee | |
Comment 4•20 years ago
|
||
landed on trunk. will close when i land on branch tomorrow at work.
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•20 years ago
|
||
landed on branch
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•