User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041126 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041126 Patch coming. Reproducible: Always Steps to Reproduce: 1. 2. 3.

#0 0x002a67a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2 #1 0x003457f6 in __nanosleep_nocancel () from /lib/tls/libc.so.6 #2 0x0034561f in sleep () from /lib/tls/libc.so.6 #3 0x080565ed in ah_crap_handler (signum=11) at nsSigHandlers.cpp:132 #4 0x007d2b7e in nsProfileLock::FatalSignalHandler (signo=11) at nsProfileLock.cpp:209 #5 <signal handler called> #6 nsXFormsUtils::GetNodeValue (aDataNode=0x0, aNodeValue=@0xfefaafb0) at nsXFormsUtils.cpp:496 #7 0x01304927 in nsXFormsOutputElement::Refresh (this=0x9b05cb8) at nsXFormsOutputElement.cpp:250 #8 0x0130459e in nsXFormsOutputElement::AttributeSet (this=0x0, aName=0xfefaafb0, aValue=@0xfefab1b0) at nsXFormsOutputElement.cpp:197 #9 0x02367250 in nsXTFElementWrapper::SetAttr (this=0x9b05cd8, aNameSpaceID=0, aName=0x9403420, aPrefix=0x0, aValue=@0xfefab1b0, aNotify=0) at nsXTFElementWrapper.cpp:242

Just noticed that this code is being modified in Bug 265467. Allan, will you fix also this bug, or should we keep it as a separate bug?

Heh, saw it myself recently, just check this one in, fine by me.

Comment on attachment 167262 [details] [diff] [review] quick fix if bryner is busy, maybe darin could review and even check this in

Comment on attachment 167262 [details] [diff] [review] quick fix >Index: nsXFormsOutputElement.cpp >+ NS_ENSURE_TRUE(dom3Node, NS_ERROR_FAILURE); nit: maybe use NS_ENSURE_STATE(dom3Node) instead? we don't really care that much about the exception that is thrown here, and NS_ERROR_UNEXPECTED is just as good if not better than NS_ERROR_FAILURE. r=darin

i forgot to mention why i like NS_ENSURE_STATE... because it is more concise :)

(In reply to comment #6) > i forgot to mention why i like NS_ENSURE_STATE... because it is more concise :) :) I was not aware of that macro, I'll try to use that instead too.

If this is now ok, could someone check it in?

Comment on attachment 167757 [details] [diff] [review] +comment r=darin

fixed-on-trunk