Closed Bug 274156 Opened 20 years ago Closed 20 years ago

Attachment icon displayed for multipart/mixed with just one part (body)

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Windows 2000
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bigbear, Assigned: Bienvenu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0 I've received two mails from the same sender with the same subject. I.e. the both messages was replied from the same "base" message I sent so the subject is the same. The second mail have an attachment but not the first. In the inbox both messages have a symbol (in the "sort by attachment" column) indicating that they have an attachment. If I select the message or open it no attachment is shown so it seems to be only in inbox window there is something wrong. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Select the message which has an attachment icon but no apparent attachment. In the menu, select View | Message Source In the window, look down the list of headers for one beginning with Content-Type: What is that header?
(In reply to comment #1) > Select the message which has an attachment icon but no apparent attachment. > In the menu, select View | Message Source > > In the window, look down the list of headers for one beginning with > Content-Type: > What is that header? Here is the content: Content-type: multipart/mixed; boundary="Boundary_(ID_xiHpxm8gdao2o6S0uY4V5Q)" X-Virus-Scanned: by amavisd-new at mai.liu.se X-Spam-Checker-Version: SpamAssassin 2.64-liu_20041015_1656 (2004-01-11) on avalon.unit.liu.se X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.64-liu_20041015_1656 References: <41B7505E.8030609@student.liu.se> X-Authentication-warning: water.mai.liu.se: pgand owned process doing -bs Original-recipient: rfc822;bjoli035@student.liu.se This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --Boundary_(ID_xiHpxm8gdao2o6S0uY4V5Q) Content-type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 8BIT
Well, multipart/mixed implies that there is an attachment, so the icon is being displayed correctly. If you scroll down in the message source, you'll the various parts -- each of them will (or should) also have its own Content-Type. You've already shown the Content-Type of the first part (the message body) which is text/plain. Are there any further parts below? Another question: does the icon (in the thread pane) continue to display once the message has been loaded? Incidentally, which version of TB are you using? I'm assuming 1.0; if you're running with something older, you definitely should update because there has been a recent change with how this icon is handled.
(In reply to comment #3) > If you scroll down in the message source, you'll the various parts -- each of > them will (or should) also have its own Content-Type. You've already shown the > Content-Type of the first part (the message body) which is text/plain. Are > there any further parts below? No, not for the mail with no attachment. If I look at the source for the mail actually containing an attachment there are Content-Type for the attachment itself as you mention. It looks like this: --Boundary_(ID_s22lL+tbXbpw7gh7amp/Zg) Content-id: <Pine.GSO.4.61.0412091537370.22663@sunray2.mai.liu.se> Content-type: APPLICATION/PDF; name=FSTAMS07.pdf Content-transfer-encoding: BASE64 Content-disposition: attachment; filename=FSTAMS07.pdf Content-description: To summarize, the mail that is indicated to contain an attachment but actually don't contain one have two Content-Type entries Content-type: multipart/mixed; in header Content-type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed before message body And the mail that really have an attachment contain these three Content-Type entries: Content-type: multipart/mixed; boundary="Boundary_(ID_s22lL+tbXbpw7gh7amp/Zg)" in header Content-type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed before mesage body Content-type: APPLICATION/PDF; name=FSTAMS07.pdf below message body, before the attachment > Another question: does the icon (in the thread pane) continue to display once > the message has been loaded? Yes. Also, if I open the mail, I don't see any attachment field in the mail. I mean, in the mail that actually have an attachment the pdf-file attached is displayed. In the other mail no attachment-field (I guess it could have shown an empty attachment-field or something). > Incidentally, which version of TB are you using? I'm assuming 1.0; if you're > running with something older, you definitely should update because there has > been a recent change with how this icon is handled. Yes, I'm running TB 1.0.
The subject is invalidly encoded -- it's declared in Base64, which requires that the encoded string be an even multiple of 4 bytes; this string is 34 bytes, the two '=' signs at the end (before the terminating "?=") are superfluous. The dupe has a discussion on whether Mozilla should or should not allow superfluous padding. *** This bug has been marked as a duplicate of 227290 ***
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Sorry, I'm an idiot -- that comment was posted into the wrong bug.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
OK, I can reproduce this. Since we hide attachment icons when there is a vCard attachment, I think we should be able to hide the attachment icons where there is *no* attachment. Reproduced with TB 1.0, Win2K. Probably belongs in All/All.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → Windows 2000
Summary: Attachment from mail with same subject show up → Attachment icon displayed for multipart/mixed with just one part (body)
I have a fix for this - I'm just testing it out.
Assignee: mscott → bienvenu
Attached patch proposed fix (deleted) — Splinter Review
basically, always set the attachment flag when finished downloading a message, in case it was set incorrectly by the header parsing code.
Attachment #169392 - Flags: superreview?(mscott)
Comment on attachment 169392 [details] [diff] [review] proposed fix can you check this into the branch too David?
Attachment #169392 - Flags: superreview?(mscott) → superreview+
fixed on trunk and aviary 1.0 branch (post 1.0)
Status: NEW → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
I think this patch/fix may have caused another bug in recent nightlies preventing attachments from being displayed in some configurations (maybe specific to IMAP?). Please refer to the following post: http://forums.mozillazine.org/viewtopic.php?t=201776 Can someone please confirm this problem and reopen this bug if necessary? Thanks, Alan
(In reply to comment #12) > I think this patch/fix may have caused another bug in recent nightlies > preventing attachments from being displayed in some configurations (maybe > specific to IMAP?). Please refer to the following post: > > http://forums.mozillazine.org/viewtopic.php?t=201776 > > Can someone please confirm this problem and reopen this bug if necessary? Hmmm... I wonder if that's the same as bug 278595.
Apparently, this is not an IMAP vs. POP issue, and I don't think it is the same as bug 278595 based on that bug's description. However, I think I have found the problem. Apparently, it is caused by the Enigmail extension in combination with the patch checked in on 12/22/2004 in this bug. There are two workarounds I have tested to remedy this problem, but it really needs to be fixed in the current code (either in Thunderbird or Enigmail or both): 1) Disable the Enigmail extension. It does not have to be uninstalled; disabling it alone works fine. 2) Revert to the a nightly build or release prior to 12/23/2004. Alan
Blocks: attach-icon
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: