Closed
Bug 27417
Opened 25 years ago
Closed 3 years ago
When tree item deleted, next item should be selected (selection should not be destroyed)
Categories
(Core :: XUL, defect, P3)
Tracking
()
RESOLVED
INCOMPLETE
Future
People
(Reporter: mpt, Unassigned)
References
Details
(Whiteboard: ue1 [need info])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Build: 2000021014
To reproduce:
* Start Mozilla. Browse with cookies enabled, until you have collected two or
more cookies.
* Open the Cookie Manager window.
* Select the first cookie in the list, and click Remove Cookie.
What should happen:
* The cookie is deleted, and the next cookie in the list becomes
selected.
What actually happens:
* The cookie is deleted, but the next cookie is not selected. This makes
deleting multiple cookies rather tedious.
Ben, giving this to you because you'll know if this problem is specific to the
cookie manager, or to the widget itself; if it's a problem with the widget, you
can give it to XP Toolkit/Widgets.
Comment 2•25 years ago
|
||
need to create some JS extensions to the tree widget API to support nifty little
things like this everywhere... M16 so I can do this the Right Way.
Status: NEW → ASSIGNED
Target Milestone: M16
Comment 4•25 years ago
|
||
changing qa contact to jrgm@netscape.com on some random bugs
QA Contact: paulmac → jrgm
Updated•24 years ago
|
Summary: When listbox item deleted, next item should be selected → When tree item deleted, next item should be selected (selection should not be destroyed)
Comment 6•24 years ago
|
||
setting component to trees and cc'ing hyatt.
Component: XP Apps → XP Toolkit/Widgets: Trees
Comment 7•24 years ago
|
||
This bug makes selectively deleting cookies O(n^2) for keyboard people, adding
access keyword and nominating for nsbeta1.
nav triage team:
Reassigning to hyatt. Seems like something we would like to fix.
Assignee: ben → hyatt
Status: ASSIGNED → NEW
Comment 9•24 years ago
|
||
This is supposed to work. bryner and I wrote code to auto-select the next item.
Can someone point me to a specific tree that exhibits this problem?
Status: NEW → ASSIGNED
Comment 10•24 years ago
|
||
hyatt: all of them, I think (if not, and it is indeed a base behavior of trees
now, we should fix some places where we're still manually selecting and
focusing). The tree in the cookie manager is one example.
Comment 11•24 years ago
|
||
Forget the cookie manager. Here's a simplified example of a tree that
demonstrates the problem. Select an item and press the "remove button".
Selected item gets deleted. But no automatic reselection occurs.
<?xml version="1.0"?>
<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
<?xul-overlay href="chrome://global/content/dialogOverlay.xul"?>
<!DOCTYPE window>
<window id="cookieviewer"
class="dialog"
xmlns:html="http://www.w3.org/1999/xhtml"
xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
orient="vertical">
<script type="application/x-javascript">
<![CDATA[
function remove() {
var children = document.getElementById("kids");
var mytree = document.getElementById("mytree");
var selitems = mytree.selectedItems;
for(i = 0; i < selitems.length; i++) {
document.getElementById("kids").removeChild(selitems[i]);
}
}
]]>
</script>
<tree id="mytree" class="inset" multiple="true" flex="1">
<treecolgroup>
<treecol flex="1"/>
</treecolgroup>
<treechildren id="kids" flex="1">
<treeitem>
<treerow>
<treecell class="propertylist" label="first"/>
</treerow>
</treeitem>
<treeitem>
<treerow>
<treecell class="propertylist" label="second"/>
</treerow>
</treeitem>
<treeitem>
<treerow>
<treecell class="propertylist" label="third"/>
</treerow>
</treeitem>
</treechildren>
</tree>
<button label="remove" onclick="remove()"/>
</window>
Comment 12•24 years ago
|
||
Have a specific patch which at least fixes this for cookies manager and password
manager. A more general solution will have to await whatever fix hyatt has
planned.
It's a good thing I did this because I uncovered several minor problems in the
password-manager code which my patch corrects.
Comment 13•24 years ago
|
||
Comment 14•24 years ago
|
||
It should be noted that most of the changes in this patch are either cleanup or
outright bug fixes. Only the few lines that are of the form "x.selectedIndex="
are relevant to auto-selecting after a deletion. So even if the general
solution is ever checked in, most of this patch will still be worthwhile.
Comment 15•24 years ago
|
||
cc'ing alecf for super-review
Comment 16•24 years ago
|
||
r=dbragg
Comment 17•24 years ago
|
||
now I'm really cc'ing alecf for super-review (I thought I did it yesterday but
apparently I didn't).
Comment 18•24 years ago
|
||
sr=alecf
Comment 19•24 years ago
|
||
My patch is now checked in. Leaving this open for hyatt to implement the
general solution (my patch fixed it for cookies and passwords only).
Updated•24 years ago
|
Target Milestone: --- → Future
Comment 20•23 years ago
|
||
Not an access bug, the delete key works for deleting several items at once.
Keywords: access
Comment 21•23 years ago
|
||
I marked this bug with the access keyword because it made it difficult to
delete *every other* cookie (or otherwise selectively delete cookies).
Comment 22•23 years ago
|
||
I don't understand Ruderman's comment. This bug has been fixed for the cookie
manager (as well as the password manager). See my pathch of 4/15 which has been
checked in.
Comment 23•23 years ago
|
||
>This bug has been fixed for the cookie manager (as well as the password manager).
That's why I used the past tense in my last comment :)
Reporter | ||
Comment 24•23 years ago
|
||
*** Bug 89789 has been marked as a duplicate of this bug. ***
Comment 25•23 years ago
|
||
*** Bug 105639 has been marked as a duplicate of this bug. ***
Comment 26•23 years ago
|
||
tree is no more, wontfix
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 27•23 years ago
|
||
Outliner is now called tree. Reopening.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Reporter | ||
Comment 28•23 years ago
|
||
*** Bug 135104 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 29•23 years ago
|
||
*** Bug 117267 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 30•23 years ago
|
||
*** Bug 58713 has been marked as a duplicate of this bug. ***
Comment 31•22 years ago
|
||
->component owner
Assignee: hyatt → hewitt
Status: REOPENED → NEW
QA Contact: jrgm → shrir
Comment 32•22 years ago
|
||
Would really like to see this fixed for Buffy since its a big usability issue
for Mail. Double click a mail message to open it, click delete on the open msg
toolbar. The next msg appears, but if you look at the main mail window, the msg
being displayed in the open window isn't selected. Click delete on open msg
toolbar. It doesn't work.
Comment 33•22 years ago
|
||
Bumping severity to major, since that's major loss of function in the message
window.
Severity: normal → major
Comment 34•22 years ago
|
||
Problem described in comment #32 is filed as bug 171711 (Delete in standalone
window only works once). It may or may not be connected to this bug.
Comment 35•22 years ago
|
||
Bug 171711 was responsible for not being able to delete more than one mail msg.
This bug still a top usability issue for mail thought. Open a mail msg in
standalone. Delete msg. Close standalone window. Nothing in thread pane is
selected. Disorienting for user. Not clear to user where they left off reading
msgs in thread pane.
Comment 36•22 years ago
|
||
Nav triage team: deleting in Bookmarks Manager selects the next bookmarks. Is
the problem in comment 35 specific to mail? If so, has this bug morphed and the
original problem been fixed?
hewitt, could you investigate?
Whiteboard: ue1 → ue1 [need info]
Comment 37•22 years ago
|
||
I filed Bug 172392 detailing the specific problems i see in mail. My hunch is
that its a different bug causing the mail related problems.
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
Updated•15 years ago
|
Assignee: hewitt → nobody
Comment 39•3 years ago
|
||
Closing this as resolved:incomplete given it is an old issue with no activity in the last 19 years. Also, deleting one item from a list now passes over the selection highlight to the next one, so most likely this issue is no longer reproducible.
Status: NEW → RESOLVED
Closed: 23 years ago → 3 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•