edburns Reporter
	Description • 25 years ago

It looks like a change was recently made to nsPluginHostImpl.cpp 
nsPluginHostImpl::LoadPlugins() that causes plugins to not load when Netscape 
Communicator 4.x IS NOT installed on the user's system.  

Take a look at line 2196:

http://lxr.mozilla.org/mozilla/source/modules/plugin/nglsrc/nsPluginHostImpl.cpp
#2196

2196   if(!pluginsDir4x.Valid() || !pluginsDirMoz.Valid())
2197     return NS_ERROR_FAILURE;

The first part of this || clause will always be TRUE if the user doesn't have 
Communicator 4.x installed.

	edburns Reporter
	Comment 2 • 25 years ago

I have attached a patch to fix this bug.

	av (gone) Assignee
	Comment 3 • 25 years ago

Ah, my fault. So essentially we need to replace OR with AND for that line to 
look like
2196   if(!pluginsDir4x.Valid() && !pluginsDirMoz.Valid())
2197     return NS_ERROR_FAILURE;

Do we need to return NS_OK as you suggested in the patch?

	edburns Reporter
	Comment 4 • 25 years ago

I'm not sure about NS_OK.  Since this is your module, I'd like you to make that 
call.

	av (gone) Assignee
	Comment 5 • 25 years ago

Checked in the fix. Marking appropriately.

	shrirang khanzode
	Comment 6 • 25 years ago

Verified this fix. Plugin works now even if there in no 4.x installation.