Closed
Bug 275096
Opened 20 years ago
Closed 20 years ago
Page Info | Media | Save As button non-functional
Categories
(Firefox :: Page Info Window, defect)
Firefox
Page Info Window
Tracking
()
RESOLVED
FIXED
People
(Reporter: By-Tor, Assigned: db48x)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
When clicking on the Save As button in Page Info->Media absolutely nothing
happens. This bug was first noticed in builds after 12/15 but may have occured
earlier.
Reporter | ||
Updated•20 years ago
|
OS: Windows XP → All
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•20 years ago
|
||
'Save As' does NOT work.
Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8a6) Gecko/20041217 Firefox/1.0+ Exe
Updated•20 years ago
|
Keywords: aviary-landing
Reporter | ||
Comment 2•20 years ago
|
||
Why has this been marked aviary-landing?
Comment 3•20 years ago
|
||
my bad, it's not an avary-landing.
From the JavaScript console:
Error: makeURI is not defined
Source File: chrome://browser/content/pageInfo.js
Line: 683
should be makeURL. This is a typo in Daniel Brooks's path <http://tinyurl.com/4cztv>
Keywords: aviary-landing → regression
Comment 4•20 years ago
|
||
Actually, not a typo in that patch, but the differences between Firefox and
Seamonkey.
And by the way, saveURL in Firefox accepts 6 args instead of seamonkey's 5.
http://lxr.mozilla.org/seamonkey/source/browser/base/content/contentAreaUtils.js#164
Hardware: PC → All
Assignee | ||
Comment 5•20 years ago
|
||
bah
Assignee | ||
Comment 6•20 years ago
|
||
Assignee: bugs → db48x
Status: NEW → ASSIGNED
Attachment #169175 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•20 years ago
|
Flags: blocking-aviary1.1?
Comment 7•20 years ago
|
||
Comment on attachment 169175 [details] [diff] [review]
patch
small little rap on ze knuckles for the lack of context, but otherwise r=me,
you probably can get sr/rs=neil, but he's not apt to review anything /browser
Attachment #169175 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #169175 -
Flags: superreview?(neil.parkwaycc.co.uk)
Comment 8•20 years ago
|
||
Comment on attachment 169175 [details] [diff] [review]
patch
Ah, but you wanted rs=me for xpfe right? ;-)
Attachment #169175 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment 9•20 years ago
|
||
any chance it'll get in the trunk soon? the patch has been superreviewed already
Assignee | ||
Comment 10•20 years ago
|
||
Mathieu: true, but the tree only just opened
anyway, I just checked it in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 11•20 years ago
|
||
thanks, was "refreshing" the bug ;)
Updated•20 years ago
|
Flags: blocking-aviary1.1?
Comment 12•20 years ago
|
||
assuming this is the bug corresponding to your Feb 4, 2005 checkin to the 1.7
branch (although patch doesn't match exactly and reviewers aren't marked).
Please include the bug number in your check-in comments.
Keywords: fixed1.7.6
Comment 13•20 years ago
|
||
my comments should have gone in bug 239472. Thanks for setting me straight, f.qu
And the rest of you, see why bug numbers in checkin comments are a good idea? ;-)
Keywords: fixed1.7.6
You need to log in
before you can comment on or make changes to this bug.
Description
•