Several files for downloads returns "HOME" for BeOS when asking for desktop as no 'ifdefs' are implemented for BeOS. Also there is a bug in nsLocalFileUnix:Reveal causing the parent to be shown. This will be fixed by the latest patch in bug 169506.

Reassign to patch owner

Updating bug title as it was a bit confusing.

Comment on attachment 169840 [details] [diff] [review] patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it should. r?

Comment on attachment 169840 [details] [diff] [review] patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it should. r=sergei_d

Comment on attachment 169840 [details] [diff] [review] patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it should. sr? (and possibly checkin in case of success)

/me waits and wonders who else can do a sr on this trivial patch.

Have you tried mailing the person you want the sr from?

Same patch, but updated after the license change.

Are we really supposed to change the header?

Actually, in the original patch you added your name to the list of credits. However, after you made your first patch, a new header was committed, making the patch not apply cleanly. Thus, this does not essentially change what you did, but rather just make it apply cleanly.

Comment on attachment 169840 [details] [diff] [review] patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it should. ah ok, changing to sr on updated one.

Comment on attachment 174668 [details] [diff] [review] Updated for the tri-license header change sr? (this bug has been waiting a while on SR now...)

Comment on attachment 174668 [details] [diff] [review] Updated for the tri-license header change Eesh, these are not pleasant #ifdefs, but you're not doing anything that's not already done.

Comment on attachment 174668 [details] [diff] [review] Updated for the tri-license header change tqh: this code only touches toolkit+browser, and is therefore not subject to superreview. All you need now is somebody to check it in.

This patch needs to be updated because of the prefwindow updates. pref_download.js is either gone, or on a different spot :-(

Since we couldn't find anyone to commit the changes it has gotten outdated. It's easy to create a patch just search for "Desk" (with " included) in lxr and add a XP_BEOS case that returns "Desk" for desktop. (Although I think it sucks that js-pages knows of OS-dependent code) I'm leaving this bug for someone else to fix (and try to commit).

Okay, I'll take this one. Benjamin, could you do the honours of reviewing this patch (very little has changed) and committing it if you like?

contentAreaUtils.js moved. No other changes.

Comment on attachment 180389 [details] [diff] [review] Updated after move of contenAreaUtils.js, no changes Requesting approval for aviary 1.1

Comment on attachment 180389 [details] [diff] [review] Updated after move of contenAreaUtils.js, no changes a=asa

Bug 276378 [BeOS] Download-prefs / Downloadmanager returns path to Home as Desktop patch by Niels.Reedijk@gmail.com r=bsmedberg a=asa Checked in by timeless